8000 fix audio beep by maslick · Pull Request #51 · maslick/koder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix audio beep #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2022
Merged

fix audio beep #51

merged 1 commit into from
Jan 19, 2022

Conversation

maslick
Copy link
Owner
@maslick maslick commented Jan 19, 2022

Issue #, if available: #50

Description of changes:
Removed audio initialization logic from the main scope (React's index.html) and put it to the Scan component, triggered by an onTouchStart event attached to the START button.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@maslick maslick self-assigned this Jan 19, 2022
@maslick maslick added the bug Something isn't working label Jan 19, 2022
@maslick maslick temporarily deployed to koder.dev January 19, 2022 13:16 Inactive
Copy link
Owner Author
@maslick maslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maslick maslick merged commit fbf9c6e into master Jan 19, 2022
@maslick maslick deleted the fix-issue-50-beep branch January 19, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
384C
Development

Successfully merging this pull request may close these issues.

1 participant
0