8000 Add support to generate screenshots for documentation in specs by mtancoigne · Pull Request #3981 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support to generate screenshots for documentation in specs #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 12, 2025

Conversation

mtancoigne
Copy link
Contributor

Uses `gem "capybara-screenshot"; branch from "el-cms/capybara-screenshot#custom-prefixes" (ahead of upstream with support for new options. Sadly, not yet merged upstream)

Adds a spec helper that injects and executes JS in the current page (spec/support/screenshot_helpers.rb).

CSP are disabled in test env (commit ---FIXME); let me know if you want to do this another way.

@mtancoigne mtancoigne changed the title Add first steps for documention screenshots Add support to generate documentation screenshots in specs Apr 12, 2025
@mtancoigne mtancoigne changed the title Add support to generate documentation screenshots in specs Add support to generate screenshots for documentation in specs Apr 12, 2025
@Floppy
Copy link
Collaborator
Floppy commented Apr 12, 2025

This is very cool, I love it! Thanks :D

@Floppy Floppy merged commit e26f3a2 into manyfold3d:main Apr 12, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0