8000 Updates tag cloud sorting setting and adds translation for form field by matthewbadeau · Pull Request #3927 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updates tag cloud sorting setting and adds translation for form field #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub < 8000 /div>

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2025
Merged

Updates tag cloud sorting setting and adds translation for form field #3927

merged 2 commits into from
Apr 5, 2025

Conversation

matthewbadeau
Copy link
Collaborator

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

This adds translations for the tag cloud settings sorting form field and restores the ability to save the setting.

Linked issues

Resolve #3663

Description of changes

3 changes included:

  • Fixes the save settings to now correctly save the sorting settings
  • Adds translations to the sorting fields
  • Changes the tag cloud threshold settings to a number_field rather than a text_field

@matthewbadeau matthewbadeau added this to the v1.0.0 milestone Apr 5, 2025
@Floppy Floppy merged commit 28d36d1 into main Apr 5, 2025
11 checks passed
@Floppy Floppy deleted the fix/3663_tag_cloud_sorting branch April 5, 2025 10:41
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Floppy Floppy Floppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Can't Sort Tags by Alphabetical - Reverts back to Frequency After Saving Changes
2 participants
@matthewbadeau @Floppy
0