8000 Add Spanish translation by Floppy · Pull Request #2769 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Spanish translation #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add Spanish translation #2769

merged 2 commits into from
Sep 24, 2024

Conversation

Floppy
Copy link
Collaborator
@Floppy Floppy commented Sep 24, 2024

Resolves #1841

@Floppy Floppy added feature User-facing features and product enhancements localisation Translation and localisation into different languages labels Sep 24, 2024
Floppy and others added 2 commits September 24, 2024 12:01
Co-authored-by: juanjomurga <174307823+juanjomurga@users.noreply.github.com>
Copy link
codeclimate bot commented Sep 24, 2024

Code Climate has analyzed commit 65e3e68 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.5% (0.0% change).

View more on Code Climate.

@Floppy
Copy link
Collaborator Author
Floppy commented Sep 24, 2024

@juanjomurga wow, you've been busy! I've pulled in your work so far here; let me know when you're happy with it (doesn't have to be 100%), and I'll merge it in for release.

@juanjomurga
Copy link
Contributor

Hi @Floppy!!

I had a quiet day and wanted to help with this app that I like so much. Most of the work is done and if you want to publish it, that’s fine. I will try to finish the rest once I can see the current content to see if any additional modifications are needed to what I have already created. You’re okay with that?

@Floppy
Copy link
Collaborator Author
Floppy commented Sep 24, 2024

That's great, I was just about to cut the next release, so if you're happy, in it goes!

@Floppy Floppy marked this pull request as ready for review September 24, 2024 13:41
@Floppy Floppy merged commit a3aa685 into main Sep 24, 2024
11 checks passed
@Floppy Floppy deleted the espanol branch September 24, 2024 13:42
@juanjomurga
Copy link
Contributor

Hi @Floppy
I have finished the Spanish translation. It may contain some visual errors but I would say that it no longer contains errors that prevent navigation.

When you upload a new release, let me know so I can review it and give you more information about it.
I have not been able to correctly execute the command "rake translation:" to verify the translation.

@Floppy
Copy link
Collaborator Author
Floppy commented Sep 26, 2024

@juanjomurga latest changes are merged into main now, thank you! If you're running your own instance, you could change to the edge tag to take a look. It might be a few days before I cut a new official release.

@juanjomurga
Copy link
Contributor

Hi @Floppy!!
After reviewing the changes applied and the new version of Manyfold I can confirm that all translations are correct except for some components that follow in English because they are not available to translate currently such as the search button

image

And on the other hand, I found a strange error in the html. It seems that when the application is in English everything works correctly but when I make the language change, I have a strange HTML component:

image

image

I don’t know if you need more information about this, but I am at your disposal to help you

@Floppy Floppy mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements localisation Translation and localisation into different languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full translation into Spanish
2 participants
0