8000 Refactor file access so that everything goes through Shrine by Floppy · Pull Request #2351 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor file access so that everything goes through Shrine #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 3, 2024
Merged

Refactor file access so that everything goes through Shrine #2351

merged 22 commits into from
Jul 3, 2024

Conversation

Floppy
Copy link
Collaborator
@Floppy Floppy commented Jul 2, 2024

In preparation for alternative storage backends, everything needs to go through Shrine properly.

Floppy added 21 commits July 1, 2024 17:25
@Floppy
move file glob into library
4f4afd0
@Floppy
change library glob to use the library path as a base and remove abso…
710f5cf 
…lute paths from result
@Floppy
use library glob for model file list building
88cd25b
@Floppy
rename Library#glob to #list_files
238dfa0
@Floppy
delegate file existence to storage engine
69549ea
@Floppy
change Model#exist? to Model#exists_on_storage? and delegate via library
e5deade
@Floppy
update naming of file existence checks to be clearer
f3cce05
@Floppy
remove direct file read for header checks
32070cd
@Floppy
ensure_path_case_is_correct is filesystem storage only
d0899b9
@Floppy
update stubs for file header checks
c5ae528
@Floppy
remove some test uses of #absolute_path
464d673
@Floppy
use path within library, not absolute path, for presupport detection
c304e06
@Floppy
read mesh from attachment, not absolute path
f45fc0e
@Floppy
delegate file last modified time through library
a933ddc
@Floppy
use attachment for digest calculation
b1ce1ff
@Floppy
make file conversion shrine-compatible
86d5d88
@Floppy
remove ModelFile#absolute_path
fb443f8
@Floppy
remove absolute_path from test
97de27c
@Floppy
replace absolute_path with delete_prefixed in deletion
e39b21c
@Floppy
convert move_files to be shrine compatible
a0ace3b
@Floppy
fix model moving
8586230
@Floppy Floppy force-pushed the refactor-file-access branch from c78493b to 8586230 Compare July 2, 2024 15:16
@Floppy Floppy force-pushed the refactor-file-access branch from d39fbac to b60bc7d Compare July 3, 2024 09:32
@codeclimate CodeClimate
Copy link
codeclimate bot commented Jul 3, 2024

Code Climate has analyzed commit b60bc7d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 67.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.6% (0.0% change).

View more on Code Climate.

@Floppy Floppy marked this pull request as ready for review July 3, 2024 09:34
@Floppy Floppy merged commit 09c80f2 into main Jul 3, 2024
9 checks passed
@Floppy Floppy deleted the refactor-file-access branch July 3, 2024 09:37
@Floppy Floppy added the improvement Refactors and behind-the-scenes improvements label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement Refactors and behind-the-scenes improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Floppy
0