8000 Remove unnecessary explicit render? check for phlex components by Floppy · Pull Request #4140 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unnecessary explicit render? check for phlex components #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Remove unnecessary explicit render? check for phlex components #4140

merged 1 commit into from
May 12, 2025

Conversation

Floppy
Copy link
Collaborator
@Floppy Floppy commented May 12, 2025

No description provided.

@Floppy Floppy added the improvement Refactors and behind-the-scenes improvements label May 12, 2025
@Floppy Floppy enabled auto-merge May 12, 2025 22:02
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.01% (target: -1.00%) ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8932eca) 4046 3389 83.76%
Head commit (6a99d02) 4043 (-3) 3387 (-2) 83.77% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4140) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@Floppy Floppy merged commit 0634ccd into main May 12, 2025
14 checks passed
@Floppy Floppy deleted the phlex-render-tify branch May 12, 2025 22:06
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement Refactors and behind-the-scenes improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Floppy
0