8000 Send WebSub events for object updates by Floppy · Pull Request #4099 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Send WebSub events for object updates #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our ter 8000 ms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Send WebSub events for object updates #4099

wants to merge 4 commits into from

Conversation

Floppy
Copy link
Collaborator
@Floppy Floppy commented May 2, 2025 •
edited
Loading

Resolves #4097

This is a WIP for websub support. When objects are created or updated, they will send a ping to a websub hub if set.

This is basically tested and working, but I still need to:

  • add tests and get decent coverage
  • work out how to notify about new item (topics)
  • add events for other objects: creators, collections, and probably users

@Floppy Floppy added the feature User-facing features and product enhancements label May 2, 2025
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.03% (target: -1.00%) ✅ 77.78%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3028a9a) 3837 3246 84.60%
Head commit (ddfbc5e) 3855 (+18) 3260 (+14) 84.57% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4099) 18 14 77.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature User-facing features and product enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

events
1 participant
@Floppy
0