8000 Refactor API authentication into Warden strategy by Floppy · Pull Request #4079 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor API authentication into Warden strategy #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2025
Merged

Conversation

Floppy
Copy link
Collaborator
@Floppy Floppy commented Apr 25, 2025

...so that we can wrap API authentication around the tus uploader

@Floppy Floppy added the improvement Refactors and behind-the-scenes improvements label Apr 25, 2025
@Floppy Floppy marked this pull request as draft April 25, 2025 15:53
Copy link
codacy-production bot commented Apr 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (30d54e2) 3816 3237 84.83%
Head commit (4507076) 3834 (+18) 3255 (+18) 84.90% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4079) 22 22 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@Floppy Floppy marked this pull request as ready for review May 1, 2025 15:39
@Floppy Floppy merged commit aceb89f into main May 1, 2025
14 checks passed
@Floppy Floppy deleted the warden-api-auth branch May 1, 2025 15:40
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Refactors and behind-the-scenes improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0