8000 fix text with Date: misclassified as quotations splitter by obukhov-sergey · Pull Request #183 · mailgun/talon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix text with Date: misclassified as quotations splitter #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

fix text with Date: misclassified as quotations splitter #183

merged 1 commit into from
Jan 18, 2019

Conversation

obukhov-sergey
Copy link
Member
@obukhov-sergey obukhov-sergey commented Jan 18, 2019 •
edited
Loading

fixes #73

@obukhov-sergey obukhov-sergey 8000 merged commit cdd8456 into master Jan 18, 2019
@obukhov-sergey obukhov-sergey deleted the sergey/date branch January 18, 2019 14:32
anton-efimenko
anton-efimenko reviewed Jan 18, 2019
View reviewed changes
Copy link
@anton-efimenko anton-efimenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rorytorneymf
rorytorneymf reviewed Oct 21, 2022
View reviewed changes
tests/text_quotations_test.py
@@ -807,7 +811,7 @@ def test_split_email():
>
>
"""
expected_markers = "stttttsttttetesetesmmmmmmssmmmmmmsmmmmmmmm"
expected_markers = "stttttsttttetesetesmmmmmmsmmmmmmmmmmmmmmmm"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @obukhov-sergey Hope you can help me :-)

I recently upgraded my Talon version from a version before this change to a version after, and some of my tests started failing.

I am just trying to understand this change. Looking at this test and its expectation:

image

these lines:

> > Date: Mon, 2 Apr 2012 17:44:22 +0400

> > > From: bob@xxx.mailgun.org

were previously classified as splitter lines ('s'), but are now classified as lines starting with quotation marker '>' ('m').

Was the previous behavior (classification as splitter lines) incorrect?

I am trying to figure out if I was previously relying on buggy behavior that has now been fixed? (And if so, I should update my tests).

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-efimenko anton-efimenko anton-efimenko left review comments

@rorytorneymf rorytorneymf rorytorneymf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handling of Date: From: block
3 participants
@obukhov-sergey @anton-efimenko @rorytorneymf
0