8000 Exec Doc May 15, 2025 by blimpa · Pull Request #2910 · makerdao/community · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Exec Doc May 15, 2025 #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 12, 2025
Merged

Exec Doc May 15, 2025 #2910

merged 15 commits into from
May 12, 2025

Conversation

blimpa
Copy link
Collaborator
@blimpa blimpa commented May 9, 2025 •
edited
Loading

8000
blimpa and others added 2 commits May 11, 2025 16:18
@blimpa @boet1
Apply suggestions from boet's review
4b717af 
Co-authored-by: boet <166723020+boet1@users.noreply.github.com>
@blimpa
Added links
9a9879d
0xldr
0xldr previously requested changes May 12, 2025
View reviewed changes
CivicSage3
CivicSage3 reviewed May 12, 2025
View reviewed changes
blimpa and others added 5 commits May 12, 2025 12:34
@blimpa
Update governance/votes/Executive vote - May 15, 2025.md
c916a57
@blimpa @CivicSage3
Apply suggestions from code review
0b864f8 
Co-authored-by: CivicSage3 <164015192+CivicSage3@users.noreply.github.com>
@blimpa @0xldr
Apply suggestions from code review
a9d1a08 
Co-authored-by: 0xldr <139177554+0xldr@users.noreply.github.com>
@blimpa @VoteWizard
Apply suggestions from code review
94d122b 
Co-authored-by: VoteWizard <139255802+VoteWizard@users.noreply.github.com>
@blimpa
Update Executive vote - May 15, 2025.md
1a629d2
blimpa and others added 2 commits May 12, 2025 14:13
@blimpa @VoteWizard
Update governance/votes/Executive vote - May 15, 2025.md
b59a662 
Co-authored-by: VoteWizard <139255802+VoteWizard@users.noreply.github.com>
@blimpa
Update Executive vote - May 15, 2025.md
9f1610a
MakerJanSky
MakerJanSky requested changes May 12, 2025
View reviewed changes
Copy link
Collaborator
@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor corrections before completing the checklist.

@blimpa @MakerJanSky
Apply suggestions from code review
5ee794d 
Co-authored-by: MakerJanSky <137431968+MakerJanSky@users.noreply.github.com>
@blimpa
Copy link
Collaborator Author
blimpa commented May 12, 2025

Executive Creation

Creation

  • Sync Community Git

  • Ensure you are working from the latest master branch

  • Read Associated Executive Contents sheet

  • Copy the executive template

  • Update filename

  • Update dates - exact time is not required and should be left at midnight.

  • Ensure the title refers to the most impactful/important actions included in the proposal.

  • Ensure that the summary refers to all actions included in the proposal.

  • Ensure that the publisher (entity publishing the executive on the voting portal) of the executive is listed in the preamble (at the entity level).

  • Ensure that the writers of the executive code are listed in the preamble (at the entity level).

  • Ensure that the reviewers of the executive code are listed in the preamble (at the entity level).

  • Ensure that the office-hours modifier is mentioned as part of the executive copy, if present in the executive spell code.

  • Ensure that it is clearly stated which items are affected by the GSM Delay.

  • Ensure that the GSM Delay period is clearly communicated.

  • Ensure that the proposal expiry is explicitly noted, including the length of time for which the proposal is valid.

Items

  • Add each item to the proposal details section

  • Order the items by judged impact/importance. If different from the executive contents, reorder the executive contents sheet so that they match.

  • For each item

    • Ensure the executive summary contains a high-level overview of every action contained in the proposal.
    • Ensure that each item or set of items in the executive proposal has a corresponding entry in the proposal details section.
    • Ensure that each item in the copy contains a link to the reasoning for its inclusion.
    • Ensure that each item in the copy contains a link to the authorization for its inclusion.
    • Ensure that each item in the copy contains any links required for voters to determine the context surrounding its inclusion.
    • Ensure that the framing and tense used for each item is future-conditional. Ie: "IF this executive proposal passes, THEN this action will take place."
    • Ensure that hyperlinks to documentation and/or context are added to key parameters, terms, and contracts where reasonable and possible.
    • Ensure that Ethereum and IPFS addresses are hyperlinked such that it is easy to view their details.
    • Ensure that parties implicated in the proposal outcome related to this item are aware of the wording used.

Self-Review

  • Do any '$' parameter signifiers remain? (spell address is unknown at this point)
  • Do the executive title, summary, and executive summary accurately reflect executive copy content?
  • Read the executive copy in full, with the above checklists and general readability in mind. Make any required changes.
  • Run the copy through a spelling and grammar checker - do not blindly accept suggested changes.
  • Inform the reviewer that the executive copy is ready to review
  • Commit changes, and create a PR to the Community GitHub repository.

Atlas Active Element Updates

  • Check if any Atlas active elements will need to be updated if the executive proposal passes.

  • If yes, create a PR to the next-gen-atlas repository and for each item

    • Ensure that new values are correctly listed in the Sky Atlas.html document

  • Request review of the PR from the reviewers of the executive proposal copy.

Submission

  • Merge approved executive copy PR.
  • Inform technical teams that the copy is ready and provide the link.
  • Once technical teams have provided a spell address, add it to the executive copy.
  • Update the proposals.json to set the active proposal on the portal.
  • Refresh portal cache (DUX/Jetstream can provide password)
  • Inform the community of the new executive proposal.

@MakerJanSky
Copy link
Collaborator

Executive Document Review

Content

  • Check the title refers to the most impactful/important actions included in the proposal.
  • Check that the summary refers to all actions included in the proposal.
  • Check that the publisher (entity publishing the executive on the voting portal) of the executive is listed in the preamble (at the entity level).
  • Check that the writers of the executive code are listed in the preamble (at the entity level).
  • Check that the reviewers of the executive code are listed in the preamble (at the entity level).
  • Check that the office-hours modifier is mentioned as part of the executive copy, if present in the executive spell code.
  • Check that it is clearly stated which items are affected by the GSM Delay.
  • Check that the GSM Delay period is communicated.
  • Check that the proposal expiry is explicitly noted, including the length of time for which the proposal is valid.

Items

  • Check each item is present in the proposal details section

  • Check items are ordered by judged impact/importance

  • For each item

    • Check the executive summary contains a high-level overview of the item.
    • Check that each item or set of items in the executive proposal has a corresponding entry in the proposal details section.
    • Check that the copy contains a link to the reasoning for its inclusion.
    • Check that the copy contains a link to the authorization for its inclusion.
    • Check that the copy contains any links required for voters to determine the context surrounding its inclusion.
    • Check that the framing and tense used for each item is future-conditional. Ie: "IF this executive proposal passes, THEN this action will take place."
    • Check that hyperlinks to documentation and/or context are added to key parameters, terms, and contracts where reasonable and possible.
    • Check that Ethereum and IPFS addresses are hyperlinked such that it is easy to view their details.
    • Check that parties implicated in the proposal outcome related to this item are aware of the wording used.

Final Checks

  • Read the executive copy in full, with the above checklists and general readability in mind. Raise any issues with the author.

Atlas Active Element Updates

  • Check if any Atlas active elements will need to be updated if this executive proposal passes

  • If yes N/A

    • Check that a PR to the next-gen-atlas repository has been opened by the author.
    • Check that all values being changed by the executive proposal have been correctly updated in the Sky Atlas document.
    • If all present, approve the PR so that it can be merged as soon as the executive proposal has executed.

MakerJanSky
MakerJanSky approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator
@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, all.

@VoteWizard VoteWizard dismissed 0xldr’s stale review May 12, 2025 18:27

The suggestions have been applied

CivicSage3
CivicSage3 reviewed May 12, 2025
View reviewed changes
Copy link
Collaborator
@CivicSage3 CivicSage3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell Sheet Creation

Pre-Meeting Tasks (Completed by EOD Monday before Spell Meeting)

  • Reach out to Ecosystem Actors about possible Spell Contents.
  • Inform relevant parties about deadlines (see Spell Coordination Schedule).
  • Review recent polls for to-do items.
  • Review the latest forum posts for requested items.

GovOps Meeting Tasks (Tuesdays, one week before Spell release)

  • Obtain roles for this week:
    • Spell Crafter
    • Reviewer (Dewiz)
    • Reviewer (Sidestream)
  • Review Requested Contents from Ecosystem Actors.
  • Obtain consensus on Spell Items.
  • Confirm Repeating Checklist Items:
    • Office Hours (Yes/No)
    • Global Line Modifier (Yes/No)
    • Order of Operations Issues (Yes/No)

Sheet Creation (Tuesdays, one week before Spell release)

  • Duplicate "Executive Contents (Template)" in Spell Sheet.
  • Add a new column with the spell date in the "Spell Progress Tracking" sheet and ensure the progress is kept up to date.
  • Rename duplicate tab for expected spell date (in yyyy-mm-dd format).
  • Add role and recurring items info from GovOps Meeting.
  • Add Spell Items as formatted in the sheet.
  • Complete and confirm checksums for DAI and MKR transfers.
  • SubDAO Spell Crafter delivered the SubDAO spell address and spell PR in Discord with no differences in the code.

Obtain Confirmations for listed items (Wednesday, confirmations due EOD Friday)

  • Reach out to relevant Ecosystem Actors for item-specific confirmations.
  • Correct any discrepancies.
  • Confirm items for the Governance Confirm column.

@VoteWizard
Copy link
Collaborator

Hash of the Document Before Merging

Command:
cast keccak -- "$(wget 'https://raw.githubusercontent.com/makerdao/community/c725e29dadf93028ee3b7a1fd1005d1d3c68108b/governance/votes/Executive%20vote%20-%20May%2015%2C%202025.md' -q -O - 2>/dev/null)"

Hash:
0x013791bc1a62792a2dc997e3deb0a1218d1db4da9163c373a7197b034cd271a1

The hash matches with the outcome of this online tool:
https://emn178.github.io/online-tools/keccak_256.html

@MakerJanSky
Copy link
Collaborator

Confirming a hash of -

0x013791bc1a62792a2dc997e3deb0a1218d1db4da9163c373a7197b034cd271a1

@CivicSage3 CivicSage3 merged commit af7d1ba into makerdao:master May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xldr 0xldr 0xldr left review comments

@VoteWizard VoteWizard VoteWizard left review comments

@boet1 boet1 boet1 left review comments

@MakerJanSky MakerJanSky MakerJanSky approved these changes

@CivicSage3 CivicSage3 CivicSage3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blimpa @MakerJanSky @VoteWizard @0xldr @CivicSage3 @boet1
0