8000 Improve Transaction-list component by agranado2k · Pull Request #559 · maestrano/impac-angular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Transaction-list component #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2018
Merged

Improve Transaction-list component #559

merged 3 commits into from
Jun 19, 2018

Conversation

agranado2k
Copy link
Contributor
  • merge the options to delete transactions (only one and all recurring)

@agranado2k
Improve Transaction-list component
3c37fd7 
 - merge the options to delete transactions (only one and all recurring)
@agranado2k agranado2k requested a review from xaun June 13, 2018 15:07
@agranado2k agranado2k mentioned this pull request Jun 13, 2018
Closed
@agranado2k agranado2k requested a review from MarcoBgn June 13, 2018 15:09
@agranado2k agranado2k added this to the v1.9.0 milestone Jun 13, 2018
MarcoBgn
MarcoBgn reviewed Jun 14, 2018
View reviewed changes
Copy link
@MarcoBgn MarcoBgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agranado2k just a comment about the trxGroupId

src/components/common/transactions-list/transactions-list.component.coffee Outdated
trx.recurring = false
else
return unless trx.recurring_parent
trxGroupId = trx.recurring_parent
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be trx.recurring_parent.id here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no because trx.recurring_parent is already id... the name is not good... should be trx.recurring_parent_id. I agree.. but the resource in Bolt is like it... :/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, can you add a comment to avoid future headaches? :)

@agranado2k agranado2k changed the base branch from 1.8 to 1.9 June 19, 2018 11:43
@agranado2k agranado2k merged commit c804908 into maestrano:1.9 Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoBgn MarcoBgn MarcoBgn approved these changes

@xaun xaun Awaiting requested review from xaun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@agranado2k @MarcoBgn
0