8000 Fix/config paths by m4sc0 · Pull Request #4 · madalinpopa/gocost · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/config paths #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/config paths #4

wants to merge 2 commits into from

Conversation

m4sc0
Copy link
@m4sc0 m4sc0 commented Jun 11, 2025

Fixed the data and config directory locations:

  • Configuration is now stored at $XDG_CONFIG_HOME or ~/.config/gocost
  • Data is now stored at $XDG_DATA_HOME or ~/.local/share/gocost

Closes #2

m4sc0 added 2 commits June 11, 2025 11:00
@m4sc0
Fixed data and config directory locations:
b0e1b93 
- Config is now stored in $XDG_CONFIG_HOME or ~/.config/gocost
- Data is now stored in $XDG_DATA_HOME or ~/.local/share/gocost
@m4sc0
Fixed comments
0576ba9
@m4sc0
Copy link
Author
m4sc0 commented Jun 11, 2025

Oops, I forgot to update the tests in this PR. They are currently failing because I split the original getDefaultDataDir function into two separate functions (getDataDir and getConfigDir), so the tests need to be adapted accordingly.

I’m really sorry, I can’t take care of the test updates right now. If possible, @madalinpopa could either wait until the weekend and I’ll fix them, or feel free to adjust them directly if you prefer. Thanks a lot!

@madalinpopa
Copy link
Owner

No worries at all, and no rush on this! Thanks so much for contributing – I really appreciate your work on this PR. Please feel free to get to the test updates whenever you're able to.
And of course, if you have any questions or need anything else at all, just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Storage
2 participants
@m4sc0 @madalinpopa
0