8000 Correct the centrifugal buoyancy term by ygaillard · Pull Request #50 · magic-sph/magic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the centrifugal buoyancy term #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ygaillard
Copy link

The centrifugal buoyancy in a rotating reference frame, commonly defined as:
betaDeltaTOmega^2d^4/nu^2rsin(theta)[-sin(theta),-cos(theta),0]
is corrected according to the scaling [r^2;sin(theta)/r,sin(theta)/r] described in the documentation.
The factor before DiRaE/Pr returns betaDeltaTOmega^2d^4*/nu^2.

The implementation before could not show according result in benchmark test.

The centrifugal buoyancy in a rotating reference frame
commonly defined as:
beta*DeltaT*Omega^2*d^4*/nu^2*r*sin(theta)[-sin(theta),-cos(theta),0]
is corrected according to the scaling [r^2;sin(theta)/r,sin(theta)/r].
@ygaillard ygaillard 646E marked this pull request as draft February 12, 2025 14:04
@ygaillard ygaillard marked this pull request as ready for review February 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0