8000 Grouped product frontend quantity validation added and code refactor by Mohamed-Asar · Pull Request #39480 · magento/magento2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Grouped product frontend quantity validation added and code refactor #39480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: 2.4-develop
Choose a base branch
from
Open

Grouped product frontend quantity validation added and code refactor #39480

wants to merge 33 commits into from

Conversation

Mohamed-Asar
Copy link
Contributor

Description (*)

Grouped Product Frontend Quantity validation added

Related Pull Requests

Fixed Issues (if relevant)

  1. Grouped Product Frontend Quantity Validations are Missing #39479
  2. Magento 2.4.7 minAllowed missing product order qty  #39142

Manual testing scenarios (*)

1.Create a Grouped Product and associate it with child products.
2. Set the following quantity properties for one of the child products:
- Minimum Qty Allowed in Shopping Cart: 2
- Maximum Qty Allowed in Shopping Cart: 10
- Qty Increments: 2
3.Open the Product Detail Page (PDP) of the Grouped Product and test invalid quantities for the selected child product (e.g., 1, 3, or 11) to confirm that invalid inputs are restricted.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link
m2-assistant bot commented Dec 15, 2024

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 15, 2024
@m2-community-project m2-community-project bot added Progress: pending review Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Dec 15, 2024
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests.

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
8000 Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Jan 15, 2025
@engcom-Bravo
Copy link
Contributor

Hi @Mohamed-Asar,

Thanks for your Contribution!!.

Could you please resolve the Conflicts to proceed further.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Changes Requested in Community Dashboard May 28, 2025
@Mohamed-Asar
Copy link
Contributor Author

@engcom-Bravo I fixed the conflicts, please check

@engcom-Bravo engcom-Bravo requested a review from engcom-Hotel May 28, 2025 08:13
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard May 28, 2025
@engcom-Bravo engcom-Bravo moved this from Changes Requested to Pending Review in Community Dashboard May 28, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard May 29, 2025
@engcom-Bravo engcom-Bravo self-assigned this May 30, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard May 30, 2025
@engcom-Bravo
Copy link
Contributor
engcom-Bravo commented May 30, 2025 •
edited
Loading

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create a Grouped Product and associate it with child products.

  • Set the following quantity properties for one of the child products:

    • Minimum Qty Allowed in Shopping Cart: 2
    • Maximum Qty Allowed in Shopping Cart: 10
    • Qty Increments: 2

  • .Open the Product Detail Page (PDP) of the Grouped Product and test invalid quantities for the selected child product (e.g., 1, 3, or 11) to confirm that invalid inputs are restricted.

Before: ✖️ 

Screenshot 2025-05-30 at 12 13 47 pm Screenshot 2025-05-30 at 12 18 42 pm

After: ✔️

Screenshot 2025-05-30 at 1 50 03 pm Screenshot 2025-05-30 at 1 52 18 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard May 30, 2025
@engcom-Dash engcom-Dash self-assigned this May 30, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests, Unit Tests

@engcom-Dash
Copy link
Contributor

The consistent test failures for Functional B2B are known Issues and JIRA is raised for them.
Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/9ca147ac593cebfa8bb15cddfc34b291/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/24ce85251ad7e859543698323eef8b45/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007
StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest : ACQE-7971
OrderWithMultipleConfigurableProductsAdditionalStockTest : ACQE-8060

The consistent test failures for Functional CE is known Issues and JIRA is raised for the same.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/ea2a8bbe902a91cd403d34cc0f1413f7/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/c6141d1ffdcb2b88bd9059b81502ebd3/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

The consistent test failure for Functional EE is known Issues and JIRA is raised for the same. Other failures are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/213c9121f0385ecc0ad9b0794b6719f8/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2:https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/60b1d7f04550acbc39bb8209e303e64c/Functional/allure-report-ee/index.html#categories/34dd2aa3ce3269b0c73667a1e007a61f/7ad1551983068770/

image

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

@engcom-Dash
Copy link
Contributor

Static Test Failure
The consistent static test failures are not because of this code changes done in this PR. It is a known issue and has JIRA Opened for the same.

Other static failures are flaky and not related to the code changes done in this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/43110624267407c65a6507ecbcbc124b/Statics/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39480/d51b13f03f999556b38d522aca9eae1f/Statics/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issue:
"use strict" is unnecessary inside of modules: https://jira.corp.adobe.com/browse/AC-14517.

Hence moving this PR in Merge In Progress.

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

@ihor-sviziev ihor-sviziev Awaiting requested review from ihor-sviziev

Assignees

@engcom-Bravo engcom-Bravo

@engcom-Hotel engcom-Hotel

@engcom-Dash engcom-Dash

Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mohamed-Asar @engcom-Hotel @engcom-Bravo @engcom-Dash @m2-github-services @Priyakshic @magento-ct-gh-projects-svc @engcom-Charlie
0