8000 magento/magento2#39959 catalog_product_save_before observer throws date-related error when using REST API without store-level values (getFinalPrice() issue) by KrasnoshchokBohdan · Pull Request #40003 · magento/magento2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

magento/magento2#39959 catalog_product_save_before observer throws date-related error when using REST API without store-level values (getFinalPrice() issue) #40003 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#39959 catalog_product_save_before observer throws date-related error when using REST API without store-level values (getFinalPrice() issue) #40003

wants to merge 6 commits into from

Conversation

KrasnoshchokBohdan
Copy link
Contributor
@KrasnoshchokBohdan KrasnoshchokBohdan commented Jun 17, 2025 •
edited
Loading

Adjusted the processing of SpecialFromDate to ensure proper formatting when the date is provided as a DateTimeInterface instance. This prevents errors arising during getFinalPrice() execution under certain scenarios.

Description (*)

I focused on investigation error
TypeError: strtotime(): Argument #1 ($datetime) must be of type string, DateTime given in lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php:275
the reason for it must be
\Magento\Catalog\Observer\SetSpecialPriceStartDate::execute
image

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#39959

Manual testing scenarios (*)

  1. Create a custom module with an observer for catalog_product_save_before.
  2. Inside the observer, call $product->getFinalPrice().
  3. Save product from storeview scope from admin panel (check the video from issue description)
  4. Save a product using REST API: POST /rest/default/V1/products
  5. Use the following JSON payload (no store-level pricing):
payload 
{
  "product": {
    "sku": "testing-special-date",
    "price": 120,
    "status": 0,
    "visibility": 4,
    "type_id": "simple",
    "extension_attributes": {
      "stock_item": {
        "stock_id": 1,
        "qty": 207,
        "is_in_stock": true
      }
    },
    "custom_attributes": [
      {
        "attribute_code": "tax_class_id",
        "value": "2"
      },
      {
        "attribute_code": "special_price",
        "value": "100.00"
      }
    ]
  },
  "saveOptions": true
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@KrasnoshchokBohdan
magento#39959 catalog_product_save_before observer throws date-relate…
7274ed1 
…d error when using REST API without store-level values (getFinalPrice() issue)

Adjusted the processing of `SpecialFromDate` to ensure proper formatting when the date is provided as a `DateTimeInterface` instance. This prevents errors arising during `getFinalPrice()` execution under certain scenarios.
@m2-assistant M2 Assistant
Copy link
m2-assistant bot commented Jun 17, 2025

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

KrasnoshchokBohdan and others added 2 commits June 19, 2025 17:13
@KrasnoshchokBohdan
magento#39959 catalog_product_save_before observer throws date-relate…
7cac36e 
…d error when using REST API without store-level values (getFinalPrice() issue)

Updated special price logic to ensure date formats are handled consistently when calculating and setting the "special from" date. This improves compatibility and prevents potential type issues with date-related operations.
@KrasnoshchokBohdan
Merge branch '2.4-develop' into fix-for-issue-39959
ede0d0a
@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

KrasnoshchokBohdan and others added 2 commits June 23, 2025 09:34
@KrasnoshchokBohdan
magento#39959 catalog_product_save_before observer throws date-relate…
c4210d5 
…d error when using REST API without store-level values (getFinalPrice() issue)

- fix static test errors
@KrasnoshchokBohdan
Merge branch '2.4-develop' into fix-for-issue-39959
111d869
@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run Unit Tests

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jun 24, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
Pull Requests Dashboard
Status: Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrasnoshchokBohdan @engcom-Hotel
0