8000 Ignore non-amateur frequency from Repeaterbook (instead of failing) by jancona · Pull Request #87 · mycodeplug/dzcb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ignore non-amateur frequency from Repeaterbook (instead of failing) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022

Conversation

jancona
Copy link
Contributor
@jancona jancona commented May 10, 2022

Evidently Repeaterbook can return repeaters with non-amateur frequencies, which was causing dzcb to fail. This PR instead skips that repeater and logs a warning.

Copy link
Collaborator
@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable from here. Thanks for the patch.

@jancona
Copy link
Contributor Author
jancona commented May 10, 2022

Thanks for approving it. I'm seeing a "2 workflows awaiting approval" message. I assume you'll merge this when you're ready and then the workflows will run?

@masenf masenf merged commit cf34e8a into mycodeplug:main May 11, 2022
@masenf
Copy link
Collaborator
masenf commented May 11, 2022

@jancona thanks for your contribution. I approved earlier today, but I didn't have a chance to run the workflows locally and merge/release until just now.

Your fix is released in dzcb-0.3.8: https://pypi.org/project/dzcb/0.3.8/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0