dzcb.repeaterbook: limit default states #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit default states to Washington and Oregon, since this is the region where I live and the RPB API delay is 30 seconds. So avoid a long wait for 5 * 30 seconds if someone forgets to pass the state... maybe there shouldn't even be a default for this value? Add a TODO about figuring out a smart default. For the time being, users will probably pass the states of interest on the command line (generate.sh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit default states to Washington and Oregon, since this is the region where I live and the RPB
API delay is 30 seconds.
So avoid a long wait for 5 * 30 seconds if someone forgets to pass the state... maybe there shouldn't even be a default for this value?
Add a TODO about figuring out a smart default.
For the time being, users will probably pass the states of interest on the command line (generate.sh)