8000 [Feature🚀] add updateAndSubscripGroup func · Issue #3295 · mxsm/rocketmq-rust · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature🚀] add updateAndSubscripGroup func #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
578223592 opened this issue May 21, 2025 · 0 comments · Fixed by #3293
Closed

[Feature🚀] add updateAndSubscripGroup func #3295

578223592 opened this issue May 21, 2025 · 0 comments · Fixed by #3293
Assignees
@578223592
Labels
feature🚀 Suggest an idea for this project.

Comments

@578223592
Copy link
Contributor

Is Your Feature Request Related to a Problem?

No response

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@578223592 578223592 added the feature🚀 Suggest an idea for this project. label May 21, 2025
@578223592 578223592 mentioned this issue May 21, 2025
Merged
mxsm pushed a commit that referenced this issue May 25, 2025
@578223592
[ISSUE #3295]add updateAndSubscripGroup func (#3293)
7497aa6 
* feat(broker): 添加更新和创建订阅组功能

- 新增 SubscriptionGroupHandler 处理订阅组相关请求
- 实现 update_and_create_subscription_group 方法处理更新和创建订阅组
- 添加 SubscriptionGroupAttributes 和相关属性处理
- 修改 SubscriptionGroupManager 支持更新订阅组配置

* refactor(broker): 更新订阅组配置并优化版本管理

- 在 SubscriptionGroupManager 中添加 data_version 字段，用于管理数据版本
- 修改 update_subscription_group_config 方法，使其能够更新数据版本
- 优化 update_data_version 方法，根据消息存储的状态机版本生成新版本
- 调整代码结构，提高可维护性和可扩展性

* refactor(rocketmq-common):移除 ConfigManager trait 中的空行

- 删除了 ConfigManager trait 定义中的多余空行- 优化了代码结构，提高了代码的可读性和整洁性

* refactor(rocketmq-common):优化 SubscriptionGroupAttributes::all 方法- 将 HashMap::new()作为参数传递给 get_or_init 方法
- 简化了代码结构，提高了可读性

* fix build err

* perf(broker): 优化订阅组存在性检查

- 使用 contains_key 替代 get 方法来检查订阅组是否存在，提高代码效率
- 在 SubscriptionGroupAttributes 中添加 clippy::redundant_closure 注解，忽略冗余闭包警告

---------

Co-authored-by: caicai <caicai@didiglobal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@578223592 578223592

Labels
feature🚀 Suggest an idea for this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #3295]add updateAndSubscripGroup func 578223592/rocketmq-rust
1 participant
@578223592
0