fix MXContextMenu y-offset #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
approved these changes
Apr 30, 2025
b8c9f43 to
f5910ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring of
MXContextMenuin #1626 introduced an offset inydirection, so that the user would not have to scroll down if part of the pop up menu would be outside the viewable window. However, there was an issue, that it was not correctly calculated if the user already scrolled down before. It also introduced the problem that since the menu might pop up to the top, that when you have a really long list of items in the menu, they might overflow to the top instead of the bottom.Hence, I reverted this functionality, so that the y-coordinate of the context menu will be approx. where the user clicked