Add support for Android 16 #250

kelsos · 2024-12-30T22:15:44Z

8000

Fixes #

Proposed Changes

Some of the changes can be backported from the develop branch

updates targetSdk to 35, removes butterknife deals with api deprecations

app/src/main/java/com/kelsos/mbrc/repository/ModelCache.kt

codecov · 2024-12-31T23:18:32Z

Codecov Report

Attention: Patch coverage is 16.43291% with 3575 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@fbe7a4e). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...kelsos/mbrc/networking/protocol/ProtocolActions.kt	0.00%	218 Missing ⚠️
.../mbrc/networking/client/ClientConnectionManager.kt	0.00%	186 Missing and 1 partial ⚠️
app/src/main/java/com/kelsos/mbrc/AppModule.kt	0.00%	168 Missing ⚠️
.../kelsos/mbrc/platform/mediasession/RemotePlayer.kt	0.00%	137 Missing ⚠️
...ava/com/kelsos/mbrc/features/widgets/WidgetBase.kt	1.13%	87 Missing ⚠️
...om/kelsos/mbrc/networking/client/MessageHandler.kt	0.00%	80 Missing ⚠️
...brc/networking/discovery/RemoteServiceDiscovery.kt	0.00%	79 Missing ⚠️
.../kelsos/mbrc/features/library/LibrarySyncWorker.kt	0.00%	77 Missing and 1 partial ⚠️
...ava/com/kelsos/mbrc/features/queue/QueueHandler.kt	0.00%	74 Missing ⚠️
.../java/com/kelsos/mbrc/common/ui/CircleImageView.kt	0.00%	68 Missing ⚠️
... and 174 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage        ?   15.45%           
=======================================
  Files           ?      203           
  Lines           ?     4593           
  Branches        ?      598           
=======================================
  Hits            ?      710           
  Misses          ?     3827           
  Partials        ?       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

app/src/main/java/com/kelsos/mbrc/features/library/AlbumEntryAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/library/ArtistEntryAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/library/GenreEntryAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/nowplaying/NowPlayingAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/playlists/PlaylistAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/radio/RadioAdapter.kt

app/src/main/java/com/kelsos/mbrc/platform/mediasession/SessionNotificationManager.kt

github-advanced-security

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

app/src/main/java/com/kelsos/mbrc/features/library/ArtistEntryAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/library/GenreEntryAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/lyrics/LyricsAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/output/OutputSelectionDialog.kt

app/src/main/java/com/kelsos/mbrc/platform/mediasession/SessionNotificationManager.kt

app/src/main/java/com/kelsos/mbrc/features/library/TrackEntryAdapter.kt

Picks refactoring work over the rewrite branch

app/src/main/java/com/kelsos/mbrc/features/nowplaying/NowPlayingActivity.kt

app/src/main/java/com/kelsos/mbrc/features/settings/ConnectionAdapter.kt

app/src/main/java/com/kelsos/mbrc/features/minicontrol/MiniControlFragment.kt

app/src/main/java/com/kelsos/mbrc/networking/protocol/ProtocolActions.kt

app/src/main/java/com/kelsos/mbrc/platform/mediasession/AppNotificationManagerImpl.kt

app/src/main/java/com/kelsos/mbrc/networking/client/PluginUpdateCheckUseCase.kt

gradle/libs.versions.toml

Finishes migration from dbflow to room keeping the schema, Also includes the jackson to moshi migration to drop reflection, drops the last remaining usages of rxjava, and finalizes migration from mvp to mvvm.

…NowPlayingActivity

…ntations Includes boundary handling, database operations validation, and ensures callback integrity for MoveManager. Fixes dao position update logic and repository validations.

Adds cover count tracking in LibraryStats, database query in AlbumDao, and display in LibraryActivity and stats layout.

… queries Ensures proper ordering regardless of casing by applying `collate nocase` to relevant database queries across TrackDao, AlbumDao, GenreDao, and ArtistDao.

Adds comprehensive unit tests for `ArtistRepository`, covering edge cases in retrieving album artists. Fixes `ArtistDao` query to correctly fetch album artists by matching `track.album_artist` instead of `track.artist`. GitHub Issue #178

Adds unit tests in `ArtistRepositoryTest` to validate sorting that ignores the "the" prefix. Updates `ArtistDao` queries to implement case-insensitive ordering while handling artist names prefixed with "the". GitHub issue #219

Ensures proper notification creation when connected and cancellation when disconnected in `AppNotificationManager`.

GitHub Issue #61

Prevents dependency issues by excluding `com.google.protobuf` and `protolite-well-known-types` from `playImplementation` configuration in build script.

…GenreViewModel

…pository and PlaylistRepository

…mization GitHub Issue #242

sonarqubecloud · 2025-06-23T22:26:12Z

Quality Gate passed

Issues
130 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

kelsos added 2 commits December 30, 2024 11:54

refactor: update to support Android 15

5954bc3

updates targetSdk to 35, removes butterknife deals with api deprecations

refactor: move src from the kotlin directory to java

3280125

kelsos force-pushed the update/1.6.0 branch from 9dacac8 to c9632af Compare December 30, 2024 22:27

github-advanced-security bot found potential problems Dec 30, 2024

View reviewed changes

app/src/main/java/com/kelsos/mbrc/repository/ModelCache.kt Fixed Show fixed Hide fixed

app/src/main/java/com/kelsos/mbrc/repository/ModelCache.kt Fixed Show fixed Hide fixed

app/src/main/java/com/kelsos/mbrc/repository/ModelCache.kt Fixed Show fixed Hide fixed

kelsos force-pushed the update/1.6.0 branch from c9632af to 1521a69 Compare December 31, 2024 23:11

github-advanced-security bot found potential problems Dec 31, 2024

View reviewed changes

kelsos force-pushed the update/1.6.0 branch from 1521a69 to f2fd8be Compare January 1, 2025 19:57

kelsos added 9 commits January 1, 2025 21:09

refactor: fix broken layouts

44342bb

refactor: migrate build.gradle to kotlin script

e2ba370

refactor: auto-format the code

06cf22d

refactor: replace threeten backport with java.time

ad52bc0

refactor: restructure project to closer resemble develop

1f737eb

refactor: replace deprecated api calls

11baf8d

fix: replace the custom splash screen with androidx

929ab9e

refactor: remove useless FontActivity.kt

bd444d5

refactor: fix lint errors and address some warnings

0573de8

kelsos force-pushed the update/1.6.0 branch from f2fd8be to 29fec8f Compare January 1, 2025 20:12

github-advanced-security bot found potential problems Jan 1, 2025

View reviewed changes

github-advanced-security bot found potential problems 628C Jan 2, 2025

View reviewed changes

app/src/main/java/com/kelsos/mbrc/features/library/TrackEntryAdapter.kt Fixed Show fixed Hide fixed

app/src/main/java/com/kelsos/mbrc/features/library/TrackEntryAdapter.kt Fixed Show fixed Hide fixed

kelsos added 3 commits January 2, 2025 21:27

refactor: migrate from toothpick to koin

0b4fee2

refactor: migrate from picasso to coil v3

a51f165

refactor: clean up widgets and restore functionality

ec41973

Picks refactoring work over the rewrite branch

kelsos force-pushed the update/1.6.0 branch from 4e426b7 to ec41973 Compare January 2, 2025 20:28

github-advanced-security bot found potential problems Jan 4, 2025

View reviewed changes

kelsos force-pushed the update/1.6.0 branch from ec5d004 to c48634e Compare January 5, 2025 02:00

github-advanced-security bot found potential problems Jan 5, 2025

View reviewed changes

kelsos force-pushed the update/1.6.0 branch from c48634e to c16bb7e Compare January 5, 2025 20:55

github-advanced-security bot found potential problems Jan 5, 2025

View reviewed changes

app/src/main/java/com/kelsos/mbrc/networking/client/PluginUpdateCheckUseCase.kt Fixed Show fixed Hide fixed

app/src/main/java/com/kelsos/mbrc/networking/client/PluginUpdateCheckUseCase.kt Fixed Show fixed Hide fixed

kelsos force-pushed the update/1.6.0 branch 3 times, most recently from 2010303 to 76f7c20 Compare February 27, 2025 20:55

kelsos force-pushed the update/1.6.0 branch 3 times, most recently from 4ab2ac1 to 065862b Compare June 18, 2025 20:54

github-advanced-security bot found potential problems Jun 18, 2025

View reviewed changes

gradle/libs.versions.toml Fixed Show fixed Hide fixed

kelsos added 2 commits June 19, 2025 23:50

refactor: migrate from legacy libraries

b1b45e5

Finishes migration from dbflow to room keeping the schema, Also includes the jackson to moshi migration to drop reflection, drops the last remaining usages of rxjava, and finalizes migration from mvp to mvvm.

feat: moves library sync to work manager and adds progress

65dc58c

kelsos force-pushed the update/1.6.0 branch from 065862b to 65dc58c Compare June 19, 2025 21:54

kelsos added 4 commits June 21, 2025 00:26

refactor: decouple sync results flow from sync initiation

1f99baa

feat: implement enhanced connection error handling with retry logic

adb74b6

refactor: enhance widget update handling and improve error resilience

ecb3917

fix: restore default back navigation handling in LibraryActivity and …

27c16b5

…NowPlayingActivity

kelsos force-pushed the update/1.6.0 branch from bddffdc to a8e972c Compare June 21, 2025 22:22

kelsos added 5 commits June 22, 2025 01:37

test: add unit tests for NowPlayingRepository and MoveManager impleme…

18a68f9

…ntations Includes boundary handling, database operations validation, and ensures callback integrity for MoveManager. Fixes dao position update logic and repository validations.

feat: add cover count support to library stats

3e99257

Adds cover count tracking in LibraryStats, database query in AlbumDao, and display in LibraryActivity and stats layout.

fix: use case-insensitive sorting for track, album, genre, and artist…

2c8ac3e

… queries Ensures proper ordering regardless of casing by applying `collate nocase` to relevant database queries across TrackDao, AlbumDao, GenreDao, and ArtistDao.

test: add sorting logic for artists ignoring "the" prefix

8721e82

Adds unit tests in `ArtistRepositoryTest` to validate sorting that ignores the "the" prefix. Updates `ArtistDao` queries to implement case-insensitive ordering while handling artist names prefixed with "the". GitHub issue #219

kelsos force-pushed the update/1.6.0 branch from a8e972c to 8721e82 Compare June 21, 2025 23:54

kelsos added 7 commits June 22, 2025 10:21

fix: correct notification update logic in connectionStateChanged

d7ba30a

Ensures proper notification creation when connected and cancellation when disconnected in `AppNotificationManager`.

feat: implement light mode support

302e0ae

GitHub Issue #61

fix: exclude specific Firebase dependencies to resolve conflicts

682e1e7

Prevents dependency issues by excluding `com.google.protobuf` and `protolite-well-known-types` from `playImplementation` configuration in build script.

test: add unit tests for TrackRepository and update query logic

c732477

test: add unit tests for GenreRepository and enable caching in Browse…

2dcf782

…GenreViewModel

test: migrate tests to AndroidJUnit4 runner and add tests for AlbumRe…

53fd7f6

…pository and PlaylistRepository

refactor: update layouts for improved RTL support and constraint opti…

37c2a7b

…mization GitHub Issue #242

kelsos changed the title ~~Add support for Android 15~~ Add support for Android 16 Jun 28, 2025

Add support for Android 16 #250

Are you sure you want to change the base?

Add support for Android 16 #250

Uh oh!

Conversation

Uh oh!

Proposed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Quality Gate passed

Uh oh!

U 34A8 h oh!