Hammer-on and pull-off implementation #28118
Open
+1,711
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkunda
reviewed
May 26, 2025
There was a problem hiding this comment.
It's very lovely! So much about this is delightful to use.
My few bits of feedback at this stage are:
1. Default text size
It'd probably be nice to use 8pt instead of 10pt for the "H"/"P" default size. 10 is just a bit too large IMO.
2. Styles dialog page freeze issues
See video. We've definitely encountered this before, and I suspect it's a product of mixing QML components in the old dialog. Lmk if there's anything we can actually do about this.
3. Select next element in score
See video. Currently this command moves selection to the end of the score (it obviously shouldn't do this).
4. Upper/Lower-case buttons in Styles
We do actually have musescoreicon icons for the upper-case/lower-case buttons. It would be nicer to use these. Also these buttons should have tooltips please (see spec).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hammer-on and pull-off implementation