Update to C++20 standard #28014
Open
Update to C++20 standard #28014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ba9cc7 to
f7b4c61
Compare
f7b4c61 to
d8dce0e
Compare
irwir
reviewed
May 19, 2025
| @@ -535,7 +535,7 @@ void BrailleEngravingItemList::addEngravingItem(EngravingItem* el, const QString | |||
| //Manual doubling slashes '\' because Regex doesn't work. Don't know why. | |||
| QString txt = QString(); | |||
| for (int i=0; i < braille.length(); i++) { | |||
| if (braille.at(i) == '\\') { | |||
| if (braille.at(i) == QString('\\')) { | |||
There was a problem hiding this comment.
The declaration is:
const QChar at(qsizetype position) const
Hence this should have been
if (braille.at(i) == QChar('\\')) {
Or even, if it does not break the style,
if (braille[i] == QChar('\\')) {
irwir
reviewed
May 20, 2025
| @@ -535,7 +535,7 @@ void BrailleEngravingItemList::addEngravingItem(EngravingItem* el, const QString | |||
| //Manual doubling slashes '\' because Regex doesn't work. Don't know why. | |||
| QString txt = QString(); | |||
There was a problem hiding this comment.
Tautological. Default constructor creates a null string.
QString txt;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a contingent reason why this came up now (I'd like to use a C++20 feature to solve a separate issue I'm working on).
But more generally, this is an upgrade that we would have to do anyway, at some point, so why not try.