CI(github-actions): Ensure build number tagging #6033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b98d8f5 to
d8078a0
Compare
If the actual build is skipped due to a duplicate workflow run, the build number script won't run. This can be problematic if this would have been the only place where the script runs for the given commit as that'll mean that for this commit no build number will be tagged on our central server. Therefore, we now fetch the build number in a separate step that will not be skipped, if the build itself is skipped.
d8078a0 to
472a5f2
Compare
davidebeatrici
approved these changes
Jan 14, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the actual build is skipped due to a duplicate workflow run, the build number script won't run. This can be problematic if this would have been the only place where the script runs for the given commit as that'll mean that for this commit no build number will be tagged on our central server.
Therefore, we now fetch the build number in a separate step that will not be skipped, if the build itself is skipped.
Checks