Multi user and channel selection and moving #6842
8000
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding your "ugly workaround", take a look at https://doc.qt.io/qt-6/qsignalblocker.html#details |
|
yes I tried that first, it did not block anything it seems that does not work also tried it by using it when I call selectionModel->select, but these calls seem to not be really nested but be pushed to the event queue, therefore this does not work. I'm not sure why it also does not work for the mouse event, because this call was actually nested, but I guess it is not a "event" because we do not subscribe to it, but override the base method instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR with different implementaiton: https://github.com/mumble-voip/mumble/pull/1871/files?diff=split&w=1
Issue: #1829
output.mp4
0:00 Select and move multiple channels
0:24 Select channels with sub channels, causing the hierarchy to flatten
0:42 Select and move multiple users
1:00 Ctrl click channel with a selected user(causes the selection inside the channel to toggle)
1:10 Using shift to select a range
1:21 Using Ctrl+A to select users
1.39 Using Ctrl+A to select users(except users in collapsed nodes)
1:50 while users selected try to also select channels while having Ctrl pressed(channels are not selected)
2:17 same thing but having channels selected and trying to select users while Ctrl pressed(users are not selected)
Moving multiple channels and users example. User move can also be configured to ask whether to move the users or not.
I did it in a way which made the most sense to me. Opinions on that are welcome
Checks