FIX(client): Percent encoded links not clickable #5564
Conversation
|
No idea why the macos pipeline failed :/ Maybe someone can rerun it. |
|
It just does that sometimes 🤷 |
If a link contains any percent encoded characters (e.g. umlauts), the markdown parser sets a wrong offset, thus resulting in a cut off link in the log. This is fixed by adjusting the url parsing regex to include a percent symbol.
|
Did you also re-test the code with the new changes? Just to make sure I didn't mess up that RegEx ^^ |
|
Sure. Also verified with regex101, as my regex skills are not so good :p |
|
Perfect 👍 |
|
Thanks for fixing this 🔝 |
|
Any idea when we can see a release with this fix in it? |
|
There are no concrete plans for a release yet, so no. 🤷 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
|
Any chance you could make a bug fix relese soon with this fix inclded? My users are seriously discussing a move to some other voice chat software because so many links are broken. It may seem strange to you, but we send a lot of links when we speak with one another and perhaps because we are from Sweden a lot of our links have percentage signs in them. |
|
I wanted to create a new release since quire a while but I just don't have the tine to do so right now 🤷 |
|
Anything I can do to help? (I'm a software dev by trade.) |
|
Thanks for the offer but I guess pretty much everything that needs to be done, has to do with our internal infrastructure and would just require someone from our team to sit down in order to push the necessary files to the correct places. Not much that can be done from the outside, unfortunately. |
If a link contains any percent encoded characters (e.g. umlauts),
the markdown parser sets a wrong offset, thus resulting in a cut off
link in the log.
This is fixed by adjusting the url parsing regex to include a percent
symbol.
Checks