8000 Add support to linux by krolow · Pull Request #78 · muan/mojibar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 22, 2022. It is now read-only.

Add support to linux #78

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Conversation

krolow
Copy link
Contributor
@krolow krolow commented Dec 22, 2016

It adds support to linux it's not a fancy emoji but it works and helps me use emoji like I use to do in mac.

image

Copy link
Contributor
@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

🐧


#### Linux

You should install [emoji font](https://github.com/eosrei/emojione-color-font), otherwise not all emojies will be rendered properly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"emojies" should be "emoji" (or "emojis")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah man I don't know how to write this :(

let me know if it is emojis or emojies

@krolow krolow force-pushed the feature/add-support-to-linux branch from cf4e26e to 860038c Compare December 23, 2016 03:38
@krolow
Copy link
Contributor Author
krolow commented Dec 23, 2016

@zeke renamed in readme to emoji!

what do you guys think in maybe create one PR to use https://github.com/electron-userland/electron-builder

As it would support generate distro packages like deb, rpm? maybe I can add it in next PR...

@krolow
Copy link
Contributor Author
krolow commented Dec 26, 2016

I could get now colored emoji

image

I will be updating the PR with the changes and instructions to install android font with colored emoji.

@krolow krolow force-pushed the feature/add-support-to-linux branch from 860038c to 65ff8d9 Compare December 26, 2016 01:58
@@ -2,7 +2,7 @@ var menubar = require('menubar')
var app = require('electron').app
var ipc = require('electron').ipcMain
var globalShortcut = require('electron').globalShortcut
var mb = menubar({ dir: __dirname + '/app', width: 440, height: 270, icon: __dirname + '/app/Icon-Template.png', preloadWindow: true, windowPosition: 'topRight' })
var mb = menubar({ dir: __dirname + '/app', width: 440, height: 270, icon: __dirname + '/app/Icon-Template.png', preloadWindow: true, windowPosition: 'topRight', alwaysOnTop: true })
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the window was open in second plan when I have something in full screen

}

mb.showWindow()
mb.window.focus()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the window always be shown with this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, only when the window show it is setting the focus, at least in linux it is behaving properly it opens and put the focus on it, without this command it was not getting the focus

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sorry, totally missed the return.

@thekalinga
Copy link

Any plan on merging this with the master branch?

@muan muan merged commit 9c5a429 into muan:master Mar 11, 2017
@muan
Copy link
Owner
muan commented Mar 11, 2017

🙏🙏🙏🙏🙏 Sorry for dropping the ball here. Thank you so much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0