-
-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
🐧
|
||
#### Linux | ||
|
||
You should install [emoji font](https://github.com/eosrei/emojione-color-font), otherwise not all emojies will be rendered properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"emojies" should be "emoji" (or "emojis")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah man I don't know how to write this :(
let me know if it is emojis or emojies
cf4e26e
to
860038c
Compare
@zeke renamed in readme to what do you guys think in maybe create one PR to use https://github.com/electron-userland/electron-builder As it would support generate distro packages like deb, rpm? maybe I can add it in next PR... |
860038c
to
65ff8d9
Compare
65ff8d9
to
9c5a429
Compare
@@ -2,7 +2,7 @@ var menubar = require('menubar') | |||
var app = require('electron').app | |||
var ipc = require('electron').ipcMain | |||
var globalShortcut = require('electron').globalShortcut | |||
var mb = menubar({ dir: __dirname + '/app', width: 440, height: 270, icon: __dirname + '/app/Icon-Template.png', preloadWindow: true, windowPosition: 'topRight' }) | |||
var mb = menubar({ dir: __dirname + '/app', width: 440, height: 270, icon: __dirname + '/app/Icon-Template.png', preloadWindow: true, windowPosition: 'topRight', alwaysOnTop: true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the window was open in second plan when I have something in full screen
} | ||
|
||
mb.showWindow() | ||
mb.window.focus() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the window always be shown with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, only when the window show it is setting the focus, at least in linux it is behaving properly it opens and put the focus on it, without this command it was not getting the focus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah sorry, totally missed the return
.
Any plan on merging this with the master branch? |
🙏🙏🙏🙏🙏 Sorry for dropping the ball here. Thank you so much. |
It adds support to linux it's not a fancy emoji but it works and helps me use emoji like I use to do in mac.