8000 not assert task.load_data_frame(required_columns={}) by vaaaaanquish · Pull Request #180 · m3dev/gokart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

not assert task.load_data_frame(required_columns={}) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2021
Merged

not assert task.load_data_frame(required_columns={}) #180

merged 4 commits into from
Mar 16, 2021

Conversation

vaaaaanquish
Copy link
Contributor

@vaaaaanquish
Copy link
Contributor Author
8000 vaaaaanquish commented Mar 16, 2021

@Hi-king @hirosassa please check PR:)

vaaaaanquish
vaaaaanquish commented Mar 16, 2021
View reviewed changes
test/test_task_on_kart.py
@@ -314,7 +314,7 @@ def test_add_cofigureation_evaluation_order(self, mock_cmdline: MagicMock):
class DummyTaskAddConfiguration(gokart.TaskOnKart):
aa = luigi.IntParameter()

luigi.configuration.get_config().set(f'DummyTaskAddConfiguration', 'aa', '3')
luigi.configuration.get_config().set('DummyTaskAddConfiguration', 'aa', '3')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f-string is missing placeholders [F541]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Hi-king
Hi-king reviewed Mar 16, 2021
View reviewed changes
@Hi-king
Copy link
Member
Hi-king commented Mar 16, 2021

LGTM!

hirosassa
hirosassa approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator
@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hi-king Hi-king merged commit 7056c10 into master Mar 16, 2021
@Hi-king
Copy link
Member
Hi-king commented Mar 16, 2021

@vaaaaanquish Merged. Thx for your contribution!

@vaaaaanquish vaaaaanquish mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirosassa hirosassa hirosassa approved these changes

@Hi-king Hi-king Hi-king approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaaaaanquish @Hi-king @hirosassa
0