8000 Beautify Tuning GCM parameterization by IamShubhamGupto · Pull Request #85 · m2lines/L96_demo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Beautify Tuning GCM parameterization #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 5, 2023

Conversation

IamShubhamGupto
Copy link
Member

Changes:

  • minor text additions
  • Fix graph code to follow a standard pattern
  • Tried rewriting discussions section, further changes welcome

Known issues:

  • RuntimeWarning in the Estimating parameters which optimize longer trajectories section. Warnings could be disabled but generally not usually not recommended.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@IamShubhamGupto
Copy link
Member Author

@dhruvbalwada

my changes based on our discussion on Wednesday is in.

Let me know if you need help with anything else!

@IamShubhamGupto IamShubhamGupto changed the title Fix/tuning params Beautify Tuning GCM parameterization Mar 10, 2023
@dhruvbalwada dhruvbalwada merged commit 5250222 into m2lines:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0