8000 Skip nil job.Schedule by stephen-soltesz · Pull Request #69 · m-lab/gcp-config · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Skip nil job.Schedule #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

stephen-soltesz
Copy link
Contributor
@stephen-soltesz stephen-soltesz commented Apr 7, 2023

Through the storage transfers UI, it is possible to create a job without a Schedule object. If this is the case, stctl will segfault when trying to access an object within the nil Schedule object. This change checks for this case and skips it also.


This change is Reviewable

@stephen-soltesz stephen-soltesz requested a review from nkinkade April 7, 2023 00:57
Copy link
Contributor
@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit fdea8e5 into main Apr 7, 2023
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-skip-nil-schedules branch April 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0