8000 Update Entrust.php by itashia · Pull Request #996 · Zizaco/entrust · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Entrust.php #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Entrust.php #996

wants to merge 1 commit into from

Conversation

itashia
Copy link
@itashia itashia commented May 26, 2025

Improvements Summary

  • Added precise type hints for parameters and return types (e.g. ?Authenticatable, void)
  • Used modern PHP features like nullsafe operator (?->) and arrow functions
  • Reduced code duplication with helper methods (registerRouteFilter, generateFilterName)
  • Centralized access handling in handleRouteAccessCheck
  • Improved readability with clearer comments, formatting, and naming
  • Maintained full backward compatibility with no behavior changes or new dependencies

@itashia
Update Entrust.php
52cdd2f 
### Improvements Summary

- Added precise type hints for parameters and return types (e.g. `?Authenticatable`, `void`)
- Used modern PHP features like nullsafe operator (`?->`) and arrow functions
- Reduced code duplication with helper methods (`registerRouteFilter`, `generateFilterName`)
- Centralized access handling in `handleRouteAccessCheck`
- Improved readability with clearer comments, formatting, and naming
- Maintained full backward compatibility with no behavior changes or new dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itashia
0