feat: hide double square brackets in internal links #5791
Conversation
e68d901 to
61759d0
Compare
61759d0 to
319d613
Compare
There was a problem hiding this comment.
In general, I appreciate this PR. However, there is a reason I did not implement double bracket hiding, to make it easier for users to distinguish between regular links and internal links. I would suggest a separate renderer setting for that so that users can decide for themselves if they want both formatting character types hidden, or only one. You should be able to copy and reuse most of the code, and simply transfer the changes you have made to said new renderer.
| @@ -68,6 +68,18 @@ function hideLinkMarkers (view: EditorView): RangeSet<Decoration> { | |||
| }) | |||
| } | |||
|
|
|||
| // Fallback: Manually hide [[ and ]] using RegExp | |||
| @@ -68,6 +68,18 @@ function hideLinkMarkers (view: EditorView): RangeSet<Decoration> { | |||
| }) | |||
| } | |||
|
|
|||
| // Fallback: Manually hide [[ and ]] using RegExp | |||
| const docText = view.state.doc.toString() | |||
| const bracketPattern = /\[\[(.*?)\]\]/g | |||
There was a problem hiding this comment.
I advise against regular expressions where not necessary. There are syntax nodes within the syntax tree for double brackets that you can target instead. The reason the links above are handled a bit awkwardly is simply due to the complex nature of Markdown inline and reference links.
This pull request hides the double square brackets ([[ and ]]) used in internal links in the editor view, improving visual clarity.
If ZknLink AST nodes are available, the plugin hides the pipe (|) and internal target.
As a fallback, it uses a RegExp to hide brackets manually when no AST is available.
This resolves #5783.
I'm happy to receive feedback and make any changes as needed.