8000 Update Ukrainian translations by Fedik · Pull Request #5524 · Zettlr/Zettlr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Ukrainian translations #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 19, 2024
Merged

Update Ukrainian translations #5524

merged 9 commits into from
Dec 19, 2024

Conversation

Fedik
Copy link
Contributor
@Fedik Fedik commented Dec 19, 2024

Description

Update translation for Ukrainian language.

Side question: Is there a reason why the language code is uk-UK, instead of uk-UA?
I mean, in such format it is usualy <Language Code>-<Country Code>. And uk-UK it is like Ukrainian in United Kingdom 😉

Changes

Additional information

Tested on: <!-- OS including version ->

@boring-cyborg boring-cyborg
Copy link
boring-cyborg bot commented Dec 19, 2024

Thank you for opening your first PR! 🎉 We would like to thank you already for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. Please note a few things:

  • For every PR, the automated pipeline will run the linter and unit tests on
    your code. Should these fail, we will not merge your PR.
  • Activate your notifications and check your inbox regularly to respond to our
    reviews and/or comments.

We are glad for every improvement that makes its way into the app, so we look forward to collaborating on merging this PR.

@nathanlesage
Copy link
Member

Side question: Is there a reason why the language code is uk-UK, instead of uk-UA?

That is a very good question, which I can't answer :D I just added a bunch of BCP-47 tags, and I am very certain that at some point my brain just stopped working properly. I'll fix that after merging your PR, thanks for letting me know!

And, of course, thanks for the translation work ;)

@nathanlesage nathanlesage merged commit 08a66fd into Zettlr:develop Dec 19, 2024
2 checks passed
@boring-cyborg boring-cyborg
Copy link
boring-cyborg bot commented Dec 19, 2024

Your PR got merged! Welcome to the party! 🔥

@Fedik Fedik deleted the lang-uk branch December 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fedik @nathanlesage
0