8000 Update citing.md to clarify instructions by Onatcer · Pull Request #5451 · Zettlr/Zettlr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update citing.md to clarify instructions #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update citing.md to clarify instructions #5451

merged 1 commit into from
Nov 1, 2024

Conversation

Onatcer
Copy link
Contributor
@Onatcer Onatcer commented Oct 31, 2024

Description

I found that after installing Zettlr the Auto-Save Setting is turned off by default, which also means that the References Panel does not update automatically. It looks like it does only update on save, so the instructions for in citing.md did not work for me initially, because the reference of the tutorial did not show up in the sidebar.

Changes

I changed

You will notice that the book is visible there — and as you continue to include references, this list will grow!

to

After saving the file, you will notice that the book is visible there — and as you continue to include references, this list will grow!

to clarify that you need to save before the References show up.

Tested on: macOS 14.1.1

@boring-cyborg boring-cyborg
Copy link
boring-cyborg bot commented Oct 31, 2024

Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:

  • Did you follow the JSStandard coding style? - Did you comment everywhere where the necessity of a piece of code or the
    way it was implemented is not immediately obvious?
  • Did you attempt to stick as much to current coding habits as possible?
    (Note that this does not apply to pieces of code where we ourselves
    obviously violated good coding practices, which unfortunately happens
    sometimes. But please indicate this in your PR so that we know what you
    rectified!)

Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run yarn lint locally and check the file eslint_report.htm which will tell you precisely what went wrong.
Stay sharp, and thanks again!

@nathanlesage
Copy link
Member

Looks good! Indeed, the sidebar lists only update on save since there's quite some work to be done behind the scenes which I didn't want to do on every input. Good catch!

@nathanlesage nathanlesage merged commit db9d50c into Zettlr:develop Nov 1, 2024
1 check passed
@boring-cyborg boring-cyborg
Copy link
boring-cyborg bot commented Nov 1, 2024

There we go, your PR got merged! Welcome to the party! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Onatcer @nathanlesage
0