Fix some more issues #222
Merged
Fix some more issues #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- MAME is now an alias for the Arcade system
- Fix makezip script not including extra files that are dirs
- Added MSU-1 system
- Change Batocera MSU-1 mapping to Zaparoo MSU-1 system
- Fixed indexing systems on Batocera with duplicate Zaparoo system mappings
- Implemented normalize path function on Batocera
- Changed merged ID separator on optical drive reader to not conflict with ID normalizing in mappings
- Fixed ID matching for file mappings to process with normalize ID first
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues and updates naming conventions throughout the codebase. Key changes include:
- Renaming fields from “SystemId” to “SystemID” and updates in system definitions and mappings to support newly added systems (e.g. MSU-1).
- Adjustments to file and path normalization functions and mapping lookup functions to address collisions and indexing issues.
- Updates to the Batocera platform code to improve system mapping and file scanning behavior.
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/service/readers.go | Updated launcher field name to “SystemID” for consistency. |
| pkg/service/mappings.go | Renamed normalization function from NormalizeUid to NormalizeID and added debug logging. |
| pkg/readers/optical_drive/optical_drive.go | Changed merged ID separator from “:” to “/” to avoid conflicts with ID normalization. |
| pkg/platforms/windows/platform.go, pkg/platforms/steamos/platform.go, pkg/platforms/platforms.go | Updated launcher field naming convention from “SystemId” to “SystemID”. |
| pkg/platforms/mister/* | Updated system ID references to use “ID” consistently in tracker and launcher functions. |
| pkg/platforms/batocera/systemmap.go & platform.go | Revised system mapping for Batocera; replaced ReverseSystemMap with a new “toBatoceraSystems” function and added NormalizePath implementation. |
| pkg/database/systemdefs/systemdefs.go, pkg/database/mappings.go | Adjusted system definition fields from “Id” to “ID” and updated normalization calls. |
| pkg/database/gamesdb/, pkg/api/methods/, pkg/configui/configui.go | Updated system ID references across scanning, indexing, and API methods for consistency. |
Files not reviewed (1)
- pkg/assets/systems/MSU1.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.