Playlist improvements #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA23
There was a problem hiding this comment.
Pull Request Overview
This PR overhauls the playlist system and refines command handling across platforms. Key changes include updates to the Playlist structure (adding fields like ID and Playing, and a new PlaylistMedia type) and modifications to the ForwardCmd method signature in several platform implementations to return a CmdResult alongside an error. Additionally, improvements were made in the UI widget code to better handle picker selections.
Reviewed Changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/service/playlists/playlists.go | Refactored Playlist structure and added support for new commands. |
| pkg/platforms/windows/platform.go, steamos, retropie, recalbox, mac, linux, libreelec, chimeraos, bazzite, batocera | Updated ForwardCmd to return (CmdResult, error) for improved command feedback. |
| pkg/platforms/mistex/platform.go, commands.go, and pkg/platforms/mister/platform.go, launchers.go, commands.go | Updated command mapping and error handling across platform-specific implementations. |
| pkg/platforms/platforms.go | Introduced the CmdResult type and updated the Platform interface. |
| pkg/configui/widgets/widgets.go, pkg/configui/widgets/models/models.go | Enhanced Picker UI functionality and data model by adding a Selected field. |
Files not reviewed (1)
- go.mod: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overhaul of the existing playlist system.