Close a bunch of issues #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request closes several issues by adding new features and fixing bugs across different modules. Key changes include:
- Adding support for optical_reader driver identifier options and an "all" systems search in the launch.random command.
- Introducing a new API method to reload config and mappings, and allowing subdirectories in the mappings folder.
- Updating platform methods to prioritize a user config directory and embedding the app version from the environment during build.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/platforms/mister/tracker.go | Updated LookupCoreName to return a pointer; modified lookup logic and logging behavior. |
| pkg/platforms/mister/platform.go | Added user directory checks to DataDir and ConfigDir. |
| pkg/platforms/mac/platform.go | Removed temporary directory management in StartPre and Stop methods. |
| pkg/platforms/linux/platform.go | Removed temporary directory management in StartPre and Stop methods. |
| pkg/platforms/libreelec/platform.go | Removed temporary directory management in StartPre and Stop methods. |
| pkg/platforms/chimeraos/platform.go | Removed temporary directory management in StartPre and Stop methods. |
| pkg/platforms/bazzite/platform.go | Removed temporary directory management in StartPre and Stop methods. |
| pkg/platforms/batocera/platform.go | Removed explicit creation of directories in StartPre and added user dir check in getters. |
| pkg/configui/widgets/widgets.go | Updated PickerUIBuilder to construct and marshal new RunScriptParams. |
| pkg/configui/widgets/models/models.go | Changed from a Trusted pointer flag to an Unsafe boolean flag in PickerArgs. |
| pkg/config/config.go | Added an IDSource field and a ConnectionString helper; refactored mapping file discovery. |
| pkg/config/app.go | Updated app version handling and added a user dir constant. |
| pkg/cli/cli.go | Added a Reload flag and corresponding handling to trigger settings reload. |
| pkg/api/server.go | Modified method lookup to use lower-case for method names and added the reload method. |
| pkg/api/models/params.go | Extended RunParams and added a new RunScriptParams to include an Unsafe flag. |
| pkg/api/models/models.go | Added a new constant for the settings.reload method. |
| pkg/api/methods/settings.go | Implemented HandleSettingsReload to reload config and mappings. |
| pkg/api/methods/run.go | Modified run method logic to integrate the Unsafe flag and updated RunScript unmarshalling. |
| Taskfile.dist.yml | Updated the build commands to inject the app version from the environment. |
| .github/workflows/build.yml | Updated the build job to pass the APP_VERSION environment variable to the Taskfile command. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a range of new features and fixes. The changes include:
- Adding options for the optical_reader driver and support for “all” systems search in the launch.random command.
- Setting the app version dynamically from the environment during build, improving configuration by adding a user config directory, and allowing subdirectories in the mappings folder.
- Fixing issues with uppercase zap links, correcting mister tracker notifications, and adding a new API method to reload configuration.
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/platforms/mister/tracker.go | Update to lookup function to return pointers for consistency. |
| pkg/platforms/* (various) | Refactor platform directory functions to use user config dir. |
| pkg/config/config.go | Update mapping file search to support subdirectories. |
| pkg/cli/cli.go | Added a new CLI flag for reloading config and mappings. |
| pkg/api/* | Introduced new API methods and adjusted method lookup logic. |
| Taskfile.dist.yml, workflows/build.yml | Updated build commands to embed dynamic app version. |
…port, add fetch readme script
There was a problem hiding this comment.
Pull Request Overview
This PR implements several new features and fixes including API enhancements, improved configuration handling with subdirectory support, build script refactoring, and updated documentation.
- Introduces new API methods (e.g. settings reload and unsafe flag in run scripts)
- Refactors platform startup and configuration mapping logic to support user directories and subdirectories
- Updates build scripts and documentation to reflect recent changes
Reviewed Changes
Copilot reviewed 64 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/platforms/batocera/platform.go | Removed pre-start directory creation and updated device identifier casing |
| pkg/configui/widgets/widgets.go | Updated run script parameter marshaling to use a new struct |
| pkg/config/ui/models/models.go | Replaced Trusted field with Unsafe in picker args |
| pkg/config/config.go | Enhanced mapping file discovery via WalkDir and added new ReadersConnect field |
| pkg/config/app.go | Updated application version management and added a new user directory constant |
| pkg/cli/cli.go | Introduced a new Reload flag to trigger config reload operations |
| pkg/api/* | Added new API methods for settings reload and updated request method lookup |
| docs/* | Removed outdated documentation and added new scan behavior guidelines |
| Taskfile.dist.yml | Refactored build commands and environment variable handling |
| README.md | Updated links and messaging to match current project structure |
| .github/workflows/build.yml | Adjusted build steps, adding APP_VERSION injection and new platform configurations |
Files not reviewed (1)
- cmd/batocera/conf/zaparoo_service: Language not supported
Comments suppressed due to low confidence (3)
pkg/platforms/batocera/platform.go:60
- The directory creation loop in StartPre was removed; please confirm that these directories are being created elsewhere to avoid runtime issues accessing required file paths.
for _, dir := range []string{ ... }
pkg/config/config.go:455
- The usage of 'strings.ToLower' requires the 'strings' package to be imported; add the missing import to avoid compilation errors.
if strings.ToLower(filepath.Ext(d.Name())) != ".toml" {
pkg/api/server.go:66
- The call to 'strings.ToLower' requires importing the 'strings' package; please add the missing import in this file.
fn, ok := methodMap[strings.ToLower(req.Method)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.