Batocera support #210
Merged
Batocera support #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Batocera platform support for Zaparoo by integrating new deployment tasks, updating platform-specific logic (including launching, input handling, and notifier changes), and adjusting service management for Batocera.
- Added Batocera-specific deployment task in batocera.yml
- Introduced new utility functions (e.g., YesNoPrompt) and updated platform implementations in pkg/platforms/batocera
- Updated CLI service management and integration in cmd/batocera/main.go
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tasks/batocera.yml | Added deploy-arm64 task with scp/ssh commands |
| pkg/utils/utils.go | Added YesNoPrompt function |
| pkg/platforms/linux/installer/install.go | Replaced prompt with YesNoPrompt usage |
| pkg/platforms/batocera/systemmap.go | Added Batocera system mapping |
| pkg/platforms/batocera/platform.go | Updated directory management, launcher implementations, and input handling |
| pkg/platforms/batocera/keymap.go | Added keyboard and gamepad mapping specific to Batocera |
| pkg/platforms/batocera/esapi.go | Introduced helper functions for making API requests |
| pkg/database/systemdefs/systemdefs.go | Minor comment update on SystemAmiga definition |
| cmd/mistex/main.go | Adjusted ExecStart path for service execution |
| cmd/mac/main.go | Removed version print from main function |
| cmd/batocera/main.go | Revised CLI flags and service file installation logic |
Files not reviewed (1)
- cmd/batocera/conf/zaparoo_service: Language not supported
Comments suppressed due to low confidence (2)
pkg/utils/utils.go:217
- The YesNoPrompt function uses os.Stdin and strings functions (e.g., strings.TrimSpace, strings.ToLower) but these packages are not imported; please add import statements for 'os' and 'strings'.
r := bufio.NewReader(os.Stdin)
pkg/platforms/batocera/platform.go:427
- The closure defined within the loop over SystemMap captures the loop variables 'k' and 'v' by reference, which can lead to unexpected behavior; please create local copies inside the loop to ensure each closure has its own copy.
for k, v := range SystemMap {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.