[bugfix] Fix mod installation on NixOS #870
Conversation
|
|
@ImSapphire I might double check on the flatpak build if I can install mods with this. There are some weird env vars that get injected there that I assume might break flatpak. @Mistyttm can you help me verify this if everything's working as expected since your on NixOS. |
|
@silentrald can already confirm it is my friend, these patches were on the nixos package before Sapphire brought them here. They managed to get it all working |
There was a problem hiding this comment.
Should be good to merge (ﾉ^ヮ^)ﾉ*
@ImSapphire would this needs to be merged first or the other PR from NixOS? Or they are independent to one another.
|
@silentrald They are independent as of now. We're pulling from the tagged 1.5.3 release, so when the tagged 1.5.4 release with this code comes out, we can update the package on nixpkgs and remove the patches on our end nixpkgs version is completely independent from this :) |
|
Merging! 🚀 |
Scope
Inherits environment when starting wine for BSIPA installation, which matches behaviour when launching Beat Saber.
Use selected Proton's wine instead of system wine, since the wine prefix version may mismatch and cause wine to crash.
Emoji Guide
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
E.g: Blocking feedback must be addressed before merging.