Add state_dependent_path_declaration so that ifnone can be parsed
#5121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
requested changes
Jun 4, 2025
| @@ -6,7 +6,7 @@ GENFILES += frontends/verilog/verilog_lexer.cc | |||
|
|
|||
| frontends/verilog/verilog_parser.tab.cc: frontends/verilog/verilog_parser.y | |||
| $(Q) mkdir -p $(dir $@) | |||
| $(P) $(BISON) -Wall -Werror -o $@ -d -r all -b frontends/verilog/verilog_parser $< | |||
| $(P) $(BISON) -Wall -Wcex -Werror -o $@ -d -r all -b frontends/verilog/verilog_parser $< | |||
There was a problem hiding this comment.
From https://www.gnu.org/software/bison/manual/html_node/Diagnostics.html:
cex
Provide counterexamples for conflicts. See Generation of Counterexamples. Counterexamples take time to compute. The option -Wcex should be used by the developer when working on the grammar; it hardly makes sense to use it in a CI.
I don't think this should be included.
| module_path_expression: | ||
| module_path_primary | ||
| // Flatten out unary_operator to avoid shift/reduce conflict | ||
| | '!' attr module_path_primary { delete $2; } |
There was a problem hiding this comment.
Based on the existing code, these need to be freeattr($2); instead to avoid a memory leak (not that I'm sure why they're being deleted).
|
Also could you please add test(s) for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser crashed when an
ifnone-statement occured. See Bug #5092 .The
state_dependen_path_declarationfrom the specification was added to the parser file.