8000 Improve handling of the inclusive language feedback string for 'tribe' by agnieszkaszuba · Pull Request #21780 · Yoast/wordpress-seo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve handling of the inclusive language feedback string for 'tribe' #21780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

Improve handling of the inclusive language feedback string for 'tribe' #21780

merged 2 commits into from
Oct 31, 2024

Conversation

agnieszkaszuba
Copy link
Contributor
@agnieszkaszuba agnieszkaszuba commented Oct 30, 2024 •
edited
Loading

Context

  • The way the feedback string for 'tribe' was created was not readable.

Summary

This PR can be summarized in the following changelog entry:

  • Improves the handling of the feedback string for the potentially non-inclusive phrase 'tribe'.
  • [shopify-seo] Improves the handling of the feedback string for the potentially non-inclusive phrase 'tribe'.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Create a post and add the phrase tribe to it.
  • Confirm that the inclusive language analysis shows the following feedback:
    • Be careful when using tribe as it is potentially harmful. Consider using an alternative, such as group, cohort, crew, league, guild, team, union instead, unless you are referring to a culture that uses this term. Learn more.
  • Change the word to tribes and confirm that the inclusive language analysis shows the following feedback:
    • Be careful when using tribes as it is potentially harmful. Consider using an alternative, such as groups, cohorts, crews, leagues, guilds, teams, unions instead, unless you are referring to a culture that uses this term. Learn more.
  • Change the word to guru and confirm that the inclusive language analysis shows the following feedback:
    • Be careful when using guru as it is potentially harmful. Consider using an alternative, such as mentor, doyen, coach, mastermind, virtuoso, expert instead, unless you are referring to the culture in which this term originated. Learn more.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Inclusive language: Improve handling of the feedback string for 'tribe'/'tribes'

@agnieszkaszuba agnieszkaszuba added changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog Shopify This PR impacts Shopify. and removed changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Oct 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build f532672b828edb17d8e01175be85d076b2e3164a

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 57.261%
Totals Coverage Status
Change from base Build bc6d99581204013d45809c4a7fae57c52efedbed: 0.001%
Covered Lines: 13272
Relevant Lines: 22818
💛 - Coveralls

@agnieszkaszuba agnieszkaszuba marked this pull request as ready for review October 30, 2024 11:41
@Jordi-PV Jordi-PV added this to the 23.9 milestone Oct 31, 2024
@Jordi-PV
Copy link
Contributor

ACC + CR 👍

@Jordi-PV Jordi-PV merged commit e6f500f into trunk Oct 31, 2024
16 checks passed
@Jordi-PV Jordi-PV deleted the improve-handling-of-feedback-string-for-tribe branch October 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog Shopify This PR impacts Shopify.
Projects
None yet
Milestone
23.9
Development

Successfully merging this pull request may close these issues.
3 participants
@agnieszkaszuba @coveralls @Jordi-PV
0