493 add navigation sidebar with alert center and first time configuration links #21614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:Yoast/wordpress-seo into 493-add-navigation-sidebar-with-alert-center-and-first-time-configuration-links
Don't override the SidebarNavigation from the UI library (weird bugs came to life, maybe import order - not sure) But there is not need to override it, just using a separate component that wraps the original is fine
Base automatically changed from
492-setup-page-in-javascript-like-the-academy-page
to
trunk
September 10, 2024 13:45
…avigation-sidebar-with-alert-center-and-first-time-configuration-links # Conflicts: # admin/class-config.php # packages/js/src/settings/app.js
Pull Request Test Coverage Report for Build 6d7fd296b04193b6f38c3e4dd05c9de9db7de4eeDetails
💛 - Coveralls |
…avigation-sidebar-with-alert-center-and-first-time-configuration-links
igorschoester
approved these changes
Sep 11, 2024
| <LiveAnnouncer> | ||
| <LiveMessage message={ ariaLiveTitle } aria-live="polite" /> | ||
| <Helmet> | ||
| <title>Dashboard</title> |
There was a problem hiding this comment.
Should that be title or something Dashboard - route name?
| */ | ||
| const Content = () => { | ||
| return <> | ||
| <header className="yst-p-8 yst-border-b yst-border-slate-200"> |
There was a problem hiding this comment.
Why aren't you using the RouteLayout component here?
| @@ -1,5 +1,4 @@ | |||
| #wpseo-first-time-configuration { | |||
| .yst-root { | |||
| #yoast-configuration { | |||
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Dashboard new.define( 'YOAST_SEO_NEW_DASHBOARD_UI', true );Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #