Remove conditional and rename dashboard to general page. #21691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the future dashboard.
…e-new-dashboard-feature-flag # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…e-new-dashboard-feature-flag # Conflicts: # packages/js/src/general/app.js # packages/js/src/general/components/sidebar-recommendations.js # src/general/user-interface/general-page-integration.php
|
CR: ✅ |
leonidasmi
reviewed
Oct 18, 2024
There was a problem hiding this comment.
I'm pausing this in favor of https://github.com/Yoast/reserved-tasks/issues/303.
In the meantime, a couple of remarks to save us time 👇
I see a bunch of mentions of dashboard in our files, for example:
useSelectDashboard- the store is still named
@yoast/dashboard - actually a search of
dashboardinpackages/js/src/generalwill give you a lot more instances - also, the
yoast-dashboard-noticeclass in thecss/src/general-page.css
Not sure which of these we want to clean up, but let's take a conscious decision.
Also, maybe we should consider removing admin/page/dashboard.php altogether? Although that would extend the impact of our changes. So another conscious decision to be made.
…e-new-dashboard-feature-flag # Conflicts: # admin/class-config.php # src/general/user-interface/general-page-integration.php # tests/Unit/General/User_Interface/General_Page_Integration_Test.php
|
CR: ✅ |
|
Tested new dashbard (General page) without feature flag in single site and multisite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
define( 'YOAST_SEO_NEW_DASHBOARD_UI', true );in your project.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #