Update dependencies version #246
Conversation
|
Um. the first thing that pops into my head.. Am I right in thinking, either the newer DCSubtitle.xsd has an issue or the current lxml has an issue? Would that be the conclusion? |
|
I tend to think it was an issue in our DCSubtitle.xsd schema as the SubtitleType was extending the FontTypeSubtitleLevel type with an additional Text element, but looking at FontTypeSubtitleLevel, it already has the same Text element included. The nesting structure is rather complex as per specifications, I tried to check this change with some test Subtitle XML and different variations of Text / Font elements but it seems to work so far. |
|
I think the xsd is wrong and needs to be updated. I will try to look into it soon but I am extremely busy atm :/ |
|
If an issue does exist in the xsd file, please do get a comment on this so we can send it to SMPTE for review and rectification. I'll be monitoring this ticket for this possibility. |
|
Holding this while GitHub Actions is disabled on this repository. |
|
Note that this is not ready for merge yet, I'm seeing issues with cryptography refusing to parse some certificates (mostly coming from old DCPs made by easyDCP) due to this issue. This will need to be caught to avoid ClairMeta raising exceptions when checking DCPs that previously were fine. |
Updating lxml yielded this new error related to the DCSubtitle.xsd schema:
Schema validation error : local complex type: The content model is not determinist., line 39.It seems this is related to https://github.com/Ymagis/ClairMeta/pull/36/files so tagging @matmat if you have more thoughts. The current change seem to fix the immediate issue but I have to admit it may need more careful thinking, my XSD speak is rusty.