make manifest download script handle errors correctly with dash #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/bin/sh points to dash on Ubuntu 18.04 LTS. The construct
{ VAR=1; } &>/dev/null
doesn't set VAR for dash but it does for bash. Previously the script
would (benignly?) succeed, regardless of python's exit code. Here is a
typical output prior to this patch:
+ set +e
+ python args ...
+
+ [ -ne 0 ]
manifest-setup.sh: 67: [: -ne: unexpected operator
+ rm ./input-jrOOHByJvm.blf
+ RETURNCODE=0
+ set +x
+ exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/bin/sh points to dash on Ubuntu 18.04 LTS. The construct
doesn't set VAR for dash but it does for bash. Previously the script
would (benignly?) succeed, regardless of python's exit code. Here is a
typical output prior to this patch:
manifest-setup.sh: 67: [: -ne: unexpected operator