This repository was archived by the owner on May 13, 2022. It is now read-only.
Dev/controller refactor #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDarksideJ
approved these changes
Sep 29, 2019
|
This should not have been merged yet until we made the release and updated the upm packages in the project |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Simplified the controller implementation a bit * removed an unused namespace * Fixed improper removal of item from collection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleaned up controllers and data providers
See XRTK/com.xrtk.core#363