This repository was archived by the owner on May 13, 2022. It is now read-only.
Feature/controller mapping refactor #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # XRTK.Lumin/Packages/com.xrtk.lumin/Controllers/LuminController.cs
If we want any modules to run in the editor then we need to flip that flag
…ping-refactor # Conflicts: # XRTK.Lumin/Packages/com.xrtk.lumin/Controllers/LuminControllerDataProvider.cs
* Update indent levels for Lumin settings * Cache GUIContent in OnEnable * Remove blank line * Use static readonly
9 tasks
FejZa
approved these changes
Apr 26, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* updated lumin controller data provider * added controller data provider reference to the controller * updated references * updated profile reference * updated references * Added default controller definitions * removed redundant action assignments in mappings * updated references * added axis processor check * Fixed inspector * updated controller instance creation * added a default constructor * fixed TryRenderControllerModel call * removed unused reference * removed asset menu * Remove obsolete SetupDefaultInteractions (#59) * removed reference to input processor * updated reference to camera rig * updated platform flag to only be true on device If we want any modules to run in the editor then we need to flip that flag * updated hand inspector * Added Lumin camera data provider * updated lumin platform definition * updated icon * Added default lumin camera data provider profile * reverted name change * Updated constructors for data providers * Added service parent reference * cleaned up referenece * updated nearclip distance * Change requests for controller provider inspectors (#63) * Update indent levels for Lumin settings * Cache GUIContent in OnEnable * Remove blank line * Use static readonly * updated lumin camera settings * updated lumin camera data provider * only reset local positions Co-authored-by: Dino Fejzagic <dino.f@live.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Feature/controller mapping refactor #58
XRTK/com.xrtk.core#508