This repository was archived by the owner on May 13, 2022. It is now read-only.
Fix/spatial awareness #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want any modules to run in the editor then we need to flip that flag
cleaned up spatial mesh observer class a bit
# Conflicts: # XRTK.Lumin/Packages/com.xrtk.lumin/SpatialObservers/LuminSpatialMeshObserver.cs
FejZa
approved these changes
Apr 24, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* updated reference to camera rig * updated platform flag to only be true on device If we want any modules to run in the editor then we need to flip that flag * Added Lumin camera data provider * updated lumin platform definition * updated icon * Added default lumin camera data provider profile * reverted name change * Updated constructors for data providers * Added service parent reference * updated nearclip distance * updated lumin camera settings * updated lumin camera data provider * only reset local positions * fixed observer origin and orientation to work with camera system updates cleaned up spatial mesh observer class a bit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
XRTK/com.xrtk.core#528