8000 updated platform flag to only be true on device by StephenHodgson · Pull Request #61 · XRTK/com.xrtk.lumin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 13, 2022. It is now read-only.

updated platform flag to only be true on device #61

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

StephenHodgson
Copy link
Contributor

If we want any modules to run in the editor then we need to flip that flag
Copy link
Contributor
@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not getting it and didn't get an answer. Why exactly is the LuminPlatform the only defintion that lives in XRTK.Lumin while all the other platforms, including WMR and Oculus are in Core?

@StephenHodgson
Copy link
Contributor Author

We don't have a platform definition for Oculus.

We probably should move the uwp definition to the wmr package, but I was thinking that windows mixed reality was a sub set of Windows universal. You can still build 2d apps for it, which is why it's in core. Same as Android

Copy link
Contributor
@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Yeah I keep saying Oculus when I mean Android sorry.

@StephenHodgson StephenHodgson merged commit fffd87a into development Apr 12, 2020
@StephenHodgson StephenHodgson deleted the fix/platform branch April 12, 2020 14:44
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
If we want any modules to run in the editor then we need to flip that flag
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0