This repository was archived by the owner on May 13, 2022. It is now read-only.
Change requests/hand tracking #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
reviewed
Apr 4, 2020
| /// </summary> | ||
| /// <param name="handedness">Handedness to convert.</param> | ||
| /// <returns>Magic Leap hand reference.</returns> | ||
| private static MLHand ToMagicLeapHand(Handedness handedness) |
There was a problem hiding this comment.
Because it was only used in one place and I didn't think it was that useful tbh
There was a problem hiding this comment.
That and In don't think you can call this on an enum
StephenHodgson
added a commit
that referenced
this pull request
Apr 7, 2020
* Add Lumin hand controller data provider * Fix base class * Implement hand data provider interface * Remove obsolete lumin platform hand controller data provider * Create controller stub * Remove need for hand controller data provider profile * Revert Lumin speciifc hand controller * Implement Lumin data provider profile * Implement Lumin data provider profile inspector * Add XRTK assembly reference to fix inspector missing assembly issue * Fix deprecated Lumin controller API * Implement Lumin hands init / deinit * Implement hand data conversion * Implement is tracking enabled flag for Lumin * Add comment for missing rotation * Fix Lumin dependent compilation * Use LateUpdate for hand update instead of Update * Fix Unity serialization error when selecting Lumin profile asset when not targeting Lumin * Implement Lumin profile lock using new Utility * Update profile platform utility usage * Resolve merge issue * Fix platform flag for Lumin inspector * Set file icons * Create Lumin hand controller and mapping profile + inspector * Add required RefreshActiveControllers override to build * Removed base hand data provider * Move hand controller detection into existin lcdp * Adjust Lumin to recent changes * Bring back lumin hand controller data provider profile * Move LuminControllerDataProvider constructor to top * Reset Lumin data provider controller * Update hand controller data provider to fit recent changes * Remove hand tracking enabled setting (disable by removing data provider) * Update convert to set all missing joints zero fo rnow * Introduce shared hand profile configuraiton * Introduce base hand controller data provide to consume shared profile * Add label to Lumin specific in inspector * Introduce HandMeshingEnabled profile setting * Introduce "Hand Tracking System Profile" * Remove package dependency to legacy magic leap package * update lumin hand controller data provider (#51) * update lumin hand controller data provider * updated base controller data provider profile namespace * fixed compiler errors from platform changes * Fusion Lumin controller dp profiles * updated inspector * bumped minor version * Remove hand ray type setting * Change requests/hand tracking (#54) * updated references * updated references and cleaned up a bit * moved LuminHandDataConverter to Lumin.Utilities * sorted usings * fixed hand data provider inspector * Restore LuminHandControllerDataProvider * Restore lumin package dependency * fixed compiler errors * updated lumin hand controller provider profile * added a check if configuration was applied misc formatting * fix compiler errors * remove hand calls from controller data provider * Fixed lumin hand controller support (#55) * Fixed lumin hand controller support updated palm pose * only remove from registry if flag set Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com> Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Add Lumin hand controller data provider * Fix base class * Implement hand data provider interface * Remove obsolete lumin platform hand controller data provider * Create controller stub * Remove need for hand controller data provider profile * Revert Lumin speciifc hand controller * Implement Lumin data provider profile * Implement Lumin data provider profile inspector * Add XRTK assembly reference to fix inspector missing assembly issue * Fix deprecated Lumin controller API * Implement Lumin hands init / deinit * Implement hand data conversion * Implement is tracking enabled flag for Lumin * Add comment for missing rotation * Fix Lumin dependent compilation * Use LateUpdate for hand update instead of Update * Fix Unity serialization error when selecting Lumin profile asset when not targeting Lumin * Implement Lumin profile lock using new Utility * Update profile platform utility usage * Resolve merge issue * Fix platform flag for Lumin inspector * Set file icons * Create Lumin hand controller and mapping profile + inspector * Add required RefreshActiveControllers override to build * Removed base hand data provider * Move hand controller detection into existin lcdp * Adjust Lumin to recent changes * Bring back lumin hand controller data provider profile * Move LuminControllerDataProvider constructor to top * Reset Lumin data provider controller * Update hand controller data provider to fit recent changes * Remove hand tracking enabled setting (disable by removing data provider) * Update convert to set all missing joints zero fo rnow * Introduce shared hand profile configuraiton * Introduce base hand controller data provide to consume shared profile * Add label to Lumin specific in inspector * Introduce HandMeshingEnabled profile setting * Introduce "Hand Tracking System Profile" * Remove package dependency to legacy magic leap package * update lumin hand controller data provider (#51) * update lumin hand controller data provider * updated base controller data provider profile namespace * fixed compiler errors from platform changes * Fusion Lumin controller dp profiles * updated inspector * bumped minor version * Remove hand ray type setting * Change requests/hand tracking (#54) * updated references * updated references and cleaned up a bit * moved LuminHandDataConverter to Lumin.Utilities * sorted usings * fixed hand data provider inspector * Restore LuminHandControllerDataProvider * Restore lumin package dependency * fixed compiler errors * updated lumin hand controller provider profile * added a check if configuration was applied misc formatting * fix compiler errors * remove hand calls from controller data provider * Fixed lumin hand controller support (#55) * Fixed lumin hand controller support updated palm pose * only remove from registry if flag set Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com> Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
XRTK/com.xrtk.core#497