8000 Rename playspace object to XRCameraRig by FejZa · Pull Request #898 · XRTK/com.xrtk.core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 11, 2024. It is now read-only.

Rename playspace object to XRCameraRig #898

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Rename playspace object to XRCameraRig #898

merged 3 commits into from
Oct 25, 2021

Conversation

FejZa
Copy link
Contributor
@FejZa FejZa commented Oct 24, 2021

XRTK - Mixed Reality Toolkit Pull Request

Overview

As discussed in #896 the MixedRealityPlayspace was renamed to XRCameraRig. Also the configured camera rig type, IMixedRealityCameraRig, is now added to the rig game object and not the camera game object, which makes more sense and per existing documentation

/// <summary>
/// This interface is to be implemented by a <see cref="MonoBehaviour"/> and attached to the rig root object.
/// </summary>

was the intended behavior anyways.

Changes

  • MixedRealityPlayspace is now XRCameraRig
  • IMixedRealityCameraRig is now added to the rig root object instead of the camera
  • PlayspaceTransform property is now RigTransform

Breaking Changes

  • This is a breaking change but since we haven't published v0.3 yet, we can just make it part of that release.

Related Submodule Changes

  • There is submodule changes which I will create a PR for once the Core release is out, because I have to bump the Core dependency for this change anyways in the submodules

@FejZa FejZa added the Ready for review PR finished primary development, open for review label Oct 24, 2021
@FejZa FejZa merged commit 5675579 into development Oct 25, 2021
@FejZa FejZa deleted the feature/camera-rig-rename branch October 25, 2021 20:36
@FejZa FejZa self-assigned this Oct 26, 2021
This was referenced Oct 29, 2021
Merged
Merged
Merged
Merged
Merged
@FejZa FejZa mentioned this pull request Nov 22, 2021
Closed
XRTK-Build-Bot pushed a commit that referenced this pull request Jan 16, 2022
@FejZa
Rename playspace object to XRCameraRig (#898)
ce884b3 
* Rename playspace object

* Fix docs

* Update submodules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonDarksideJ SimonDarksideJ SimonDarksideJ approved these changes

@StephenHodgson StephenHodgson Awaiting requested review from StephenHodgson StephenHodgson is a code owner

Assignees

@FejZa FejZa

Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FejZa @SimonDarksideJ
0